diff options
author | KN4CK3R <admin@oldschoolhack.me> | 2022-03-23 05:54:07 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-03-23 12:54:07 +0800 |
commit | 3f280f89e7471a6dcdaefccc64a8d39188970e63 (patch) | |
tree | ff09b6dcb00b4c0ff0c436c4523d89a5c13f3a94 /routers/web/auth | |
parent | 395117d3014124b9147a1aabf76ee175e720b275 (diff) | |
download | gitea-3f280f89e7471a6dcdaefccc64a8d39188970e63.tar.gz gitea-3f280f89e7471a6dcdaefccc64a8d39188970e63.zip |
Update HTTP status codes to modern codes (#18063)
* 2xx/3xx/4xx/5xx -> http.Status...
* http.StatusFound -> http.StatusTemporaryRedirect
* http.StatusMovedPermanently -> http.StatusPermanentRedirect
Diffstat (limited to 'routers/web/auth')
-rw-r--r-- | routers/web/auth/oauth.go | 8 | ||||
-rw-r--r-- | routers/web/auth/webauthn.go | 4 |
2 files changed, 6 insertions, 6 deletions
diff --git a/routers/web/auth/oauth.go b/routers/web/auth/oauth.go index 847af52bdb..4369c333ac 100644 --- a/routers/web/auth/oauth.go +++ b/routers/web/auth/oauth.go @@ -462,7 +462,7 @@ func AuthorizeOAuth(ctx *context.Context) { log.Error("Unable to update nonce: %v", err) } } - ctx.Redirect(redirect.String(), 302) + ctx.Redirect(redirect.String()) return } @@ -544,7 +544,7 @@ func GrantApplicationOAuth(ctx *context.Context) { handleServerError(ctx, form.State, form.RedirectURI) return } - ctx.Redirect(redirect.String(), 302) + ctx.Redirect(redirect.String(), http.StatusSeeOther) } // OIDCWellKnown generates JSON so OIDC clients know Gitea's capabilities @@ -752,7 +752,7 @@ func handleAuthorizeError(ctx *context.Context, authErr AuthorizeError, redirect if redirectURI == "" { log.Warn("Authorization failed: %v", authErr.ErrorDescription) ctx.Data["Error"] = authErr - ctx.HTML(400, tplGrantError) + ctx.HTML(http.StatusBadRequest, tplGrantError) return } redirect, err := url.Parse(redirectURI) @@ -765,7 +765,7 @@ func handleAuthorizeError(ctx *context.Context, authErr AuthorizeError, redirect q.Set("error_description", authErr.ErrorDescription) q.Set("state", authErr.State) redirect.RawQuery = q.Encode() - ctx.Redirect(redirect.String(), 302) + ctx.Redirect(redirect.String(), http.StatusSeeOther) } // SignInOAuth handles the OAuth2 login buttons diff --git a/routers/web/auth/webauthn.go b/routers/web/auth/webauthn.go index bedbe7ddc3..c0cf58f3d3 100644 --- a/routers/web/auth/webauthn.go +++ b/routers/web/auth/webauthn.go @@ -39,7 +39,7 @@ func WebAuthn(ctx *context.Context) { return } - ctx.HTML(200, tplWebAuthn) + ctx.HTML(http.StatusOK, tplWebAuthn) } // WebAuthnLoginAssertion submits a WebAuthn challenge to the browser @@ -166,5 +166,5 @@ func WebAuthnLoginAssertionPost(ctx *context.Context) { } } - ctx.JSON(200, map[string]string{"redirect": redirect}) + ctx.JSON(http.StatusOK, map[string]string{"redirect": redirect}) } |