diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2021-12-10 10:51:27 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-12-10 10:51:27 +0800 |
| commit | 0a9fcf63a49799ad3b0f146c54879161bac61e10 (patch) | |
| tree | e4a6382fc1a2de403f2fec47886348dae5e72d2b /routers/web/repo/pull.go | |
| parent | 719bddcd76610a63dadc8555760072957a11cf30 (diff) | |
| download | gitea-0a9fcf63a49799ad3b0f146c54879161bac61e10.tar.gz gitea-0a9fcf63a49799ad3b0f146c54879161bac61e10.zip | |
Clean legacy SimpleMDE code (#17926)
Since we are using EasyMDE now, we do not need to keep the SimpleMDE code anymore.
This PR removes all legacy SimpleMDE code, and makes some related changes:
* `createCommentEasyMDE` can accept native DOM element, and it doesn't need `jQuery.data` to store EasyMDE editor object (as discussed about the frontend guideline).
* introduce `getAttachedEasyMDE` to get the attached EasyMDE editor object, it's easier to find all the usage of EasyMDE.
* rename variable names from `$simplemde` to `easyMDE`, the `$` was incorrect because it is a EasyMDE editor, not a jQuery object.
With this PR, it will be easier to do more refactoring or replacing EasyMDE with other editors.
Diffstat (limited to 'routers/web/repo/pull.go')
| -rw-r--r-- | routers/web/repo/pull.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/routers/web/repo/pull.go b/routers/web/repo/pull.go index b08f749cde..3882fdb5b1 100644 --- a/routers/web/repo/pull.go +++ b/routers/web/repo/pull.go @@ -701,7 +701,7 @@ func ViewPullFiles(ctx *context.Context) { setCompareContext(ctx, baseCommit, commit, ctx.Repo.Owner.Name, ctx.Repo.Repository.Name) ctx.Data["RequireHighlightJS"] = true - ctx.Data["RequireSimpleMDE"] = true + ctx.Data["RequireEasyMDE"] = true ctx.Data["RequireTribute"] = true if ctx.Data["Assignees"], err = models.GetRepoAssignees(ctx.Repo.Repository); err != nil { ctx.ServerError("GetAssignees", err) @@ -1045,7 +1045,7 @@ func CompareAndPullRequestPost(ctx *context.Context) { ctx.Data["IsDiffCompare"] = true ctx.Data["IsRepoToolbarCommits"] = true ctx.Data["RequireTribute"] = true - ctx.Data["RequireSimpleMDE"] = true + ctx.Data["RequireEasyMDE"] = true ctx.Data["RequireHighlightJS"] = true ctx.Data["PullRequestWorkInProgressPrefixes"] = setting.Repository.PullRequest.WorkInProgressPrefixes ctx.Data["IsAttachmentEnabled"] = setting.Attachment.Enabled |