diff options
| author | Eng Zer Jun <engzerjun@gmail.com> | 2023-10-06 14:49:37 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-10-06 14:49:37 +0800 |
| commit | 13d5d2e7110ca643d8ca1c7655e2a4ff89fe5b8d (patch) | |
| tree | baba009364130ebb8d458669e97a592bb2804a43 /routers/web/repo | |
| parent | 6cdeb7798ba7dc1e9d7ea7e181d51f845951b905 (diff) | |
| download | gitea-13d5d2e7110ca643d8ca1c7655e2a4ff89fe5b8d.tar.gz gitea-13d5d2e7110ca643d8ca1c7655e2a4ff89fe5b8d.zip | |
Remove redundant `len` check around loop (#27464)
This pull request is a minor code cleanup.
From the Go specification (https://go.dev/ref/spec#For_range):
> "1. For a nil slice, the number of iterations is 0."
> "3. If the map is nil, the number of iterations is 0."
`len` returns 0 if the slice or map is nil
(https://pkg.go.dev/builtin#len). Therefore, checking `len(v) > 0`
before a loop is unnecessary.
---
At the time of writing this pull request, there wasn't a lint rule that
catches these issues. The closest I could find is
https://staticcheck.dev/docs/checks/#S103
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Diffstat (limited to 'routers/web/repo')
| -rw-r--r-- | routers/web/repo/issue.go | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/routers/web/repo/issue.go b/routers/web/repo/issue.go index b6e6cef6d2..5bee8c76a9 100644 --- a/routers/web/repo/issue.go +++ b/routers/web/repo/issue.go @@ -965,10 +965,8 @@ func NewIssue(ctx *context.Context) { _, templateErrs := issue_service.GetTemplatesFromDefaultBranch(ctx.Repo.Repository, ctx.Repo.GitRepo) templateLoaded, errs := setTemplateIfExists(ctx, issueTemplateKey, IssueTemplateCandidates) - if len(errs) > 0 { - for k, v := range errs { - templateErrs[k] = v - } + for k, v := range errs { + templateErrs[k] = v } if ctx.Written() { return |