diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-04-30 20:22:23 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-30 08:22:23 -0400 |
| commit | e3750370df3be1413b1526668cbee60dc2a39f03 (patch) | |
| tree | cc61431d00e62df1a8be5e2f050105749ddad5e8 /routers/web/web.go | |
| parent | 8f4dafcd4e6b0b5d307c3e060ffe908c2a96f047 (diff) | |
| download | gitea-e3750370df3be1413b1526668cbee60dc2a39f03.tar.gz gitea-e3750370df3be1413b1526668cbee60dc2a39f03.zip | |
Use globally shared HTMLRender (#24436)
The old `HTMLRender` is not ideal.
1. It shouldn't be initialized multiple times, it consumes a lot of
memory and is slow.
2. It shouldn't depend on short-lived requests, the `WatchLocalChanges`
needs a long-running context.
3. It doesn't make sense to use FuncsMap slice.
HTMLRender was designed to only work for GItea's specialized 400+
templates, so it's good to make it a global shared instance.
Diffstat (limited to 'routers/web/web.go')
| -rw-r--r-- | routers/web/web.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/routers/web/web.go b/routers/web/web.go index bb2442fec4..e63add51f3 100644 --- a/routers/web/web.go +++ b/routers/web/web.go @@ -114,7 +114,8 @@ func Routes(ctx gocontext.Context) *web.Route { routes.RouteMethods("/apple-touch-icon.png", "GET, HEAD", misc.StaticRedirect("/assets/img/apple-touch-icon.png")) routes.RouteMethods("/favicon.ico", "GET, HEAD", misc.StaticRedirect("/assets/img/favicon.png")) - ctx, _ = templates.HTMLRenderer(ctx) + _ = templates.HTMLRenderer() + common := []any{ common.Sessioner(), RecoveryWith500Page(ctx), |