diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2022-03-29 11:21:30 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-29 05:21:30 +0200 |
| commit | d4c789dfc1c341413b77a2f21fe7339982102bed (patch) | |
| tree | 1ab6fddbe6cbd1f14b939b54c5fd7f2ca7255bd6 /routers/web/web.go | |
| parent | 90e0a402c1185827fd3d5352ca915c531ce1e7b1 (diff) | |
| download | gitea-d4c789dfc1c341413b77a2f21fe7339982102bed.tar.gz gitea-d4c789dfc1c341413b77a2f21fe7339982102bed.zip | |
Refactor repo clone button and repo clone links, fix JS error on empty repo page (#19208)
The last PR about clone buttons introduced an JS error when visiting an empty repo page:
* https://github.com/go-gitea/gitea/pull/19028
* `Uncaught ReferenceError: isSSH is not defined`, because the variables are scoped and doesn't share between sub templates.
This:
1. Simplify `templates/repo/clone_buttons.tmpl` and make code clear
2. Move most JS code into `initRepoCloneLink`
3. Remove unused `CloneLink.Git`
4. Remove `ctx.Data["DisableSSH"] / ctx.Data["ExposeAnonSSH"] / ctx.Data["DisableHTTP"]`, and only set them when is is needed (eg: deploy keys / ssh keys)
5. Introduce `Data["CloneButton*"]` to provide data for clone buttons and links
6. Introduce `Data["RepoCloneLink"]` for the repo clone link (not the wiki)
7. Remove most `ctx.Data["PageIsWiki"]` because it has been set in the `/wiki` middleware
8. Remove incorrect `quickstart` class in `migrating.tmpl`
Diffstat (limited to 'routers/web/web.go')
| -rw-r--r-- | routers/web/web.go | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/routers/web/web.go b/routers/web/web.go index 14e90348b8..485ba1a1a0 100644 --- a/routers/web/web.go +++ b/routers/web/web.go @@ -984,6 +984,7 @@ func RegisterRoutes(m *web.Route) { m.Get("/commit/{sha:[a-f0-9]{7,40}}.{ext:patch|diff}", repo.RawDiff) }, repo.MustEnableWiki, func(ctx *context.Context) { ctx.Data["PageIsWiki"] = true + ctx.Data["CloneButtonOriginLink"] = ctx.Repo.Repository.WikiCloneLink() }) m.Group("/wiki", func() { |