diff options
| author | HesterG <hestergong@gmail.com> | 2023-03-03 03:53:22 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-02 13:53:22 -0600 |
| commit | ffce336f1802b2f2298fc8fd27e815086702c812 (patch) | |
| tree | 67b84d2d52f7f05ea794360870e318475cd6c500 /routers | |
| parent | a14e6af236f3f01d757ca4ffe64d92a4a7a84d1f (diff) | |
| download | gitea-ffce336f1802b2f2298fc8fd27e815086702c812.tar.gz gitea-ffce336f1802b2f2298fc8fd27e815086702c812.zip | |
Use async await to fix empty quote reply at first time (#23168)
The reason why quote reply is empty is when quote reply is clicked, it
triggers the click function on `.comment-form-reply` button, and when
the first time this function is triggered, easyMDE for the reply has not
yet initialized, so that click handler of `.quote-reply` button in
`repo-legacy.js` got an `undefined` as easyMDE, and the following lines
which put quoted reply into the easyMDE is not executed.
The workaround in this PR is to pass the replied content to
'.comment-form-reply' button if easyMDE is not yet initialized (quote
reply first clicked) and put the replied content into it the after
easyMDE is created.
Now quote reply on first click:
https://user-images.githubusercontent.com/17645053/221452823-fc699d50-1649-4af1-952e-f04fc8d2978e.mov
<br />
Update:
The above change is not appropriate as stated in the
[comment](https://github.com/go-gitea/gitea/pull/23168#issuecomment-1445562284)
Use await instead
Close #22075.
Close #23247.
Diffstat (limited to 'routers')
0 files changed, 0 insertions, 0 deletions