diff options
| author | 赵智超 <1012112796@qq.com> | 2020-03-28 22:22:52 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-03-28 14:22:52 +0000 |
| commit | f9f2c163b12f60a6bf9c3652cdc4bdf59e3d53c4 (patch) | |
| tree | d4d2f4c8dc69ae6928d5aeb0b6ae9eeb8930e6d7 /routers | |
| parent | 828a27feeb11474b848be183a8fce2d036dec3cc (diff) | |
| download | gitea-f9f2c163b12f60a6bf9c3652cdc4bdf59e3d53c4.tar.gz gitea-f9f2c163b12f60a6bf9c3652cdc4bdf59e3d53c4.zip | |
bug: fix assignees double load bug (#10856)
Because the assigness has been loaded in
compare.go 416:
RetrieveRepoMetas(ctx, ctx.Repo.Repository, true)
then
issue.go 381
RetrieveRepoMilestonesAndAssignees(ctx, repo)
then
issue.go 361 -- 365 , they are load assignees
So the code on compare.go 425 -- 427 is double work,
and which is the reason of #10853
Signed-off-by: a1012112796 <1012112796@qq.com>
Diffstat (limited to 'routers')
| -rw-r--r-- | routers/repo/compare.go | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/routers/repo/compare.go b/routers/repo/compare.go index d7fddc4558..4769a4da1a 100644 --- a/routers/repo/compare.go +++ b/routers/repo/compare.go @@ -422,10 +422,6 @@ func CompareDiff(ctx *context.Context) { beforeCommitID := ctx.Data["BeforeCommitID"].(string) afterCommitID := ctx.Data["AfterCommitID"].(string) - if ctx.Data["Assignees"], err = ctx.Repo.Repository.GetAssignees(); err != nil { - ctx.ServerError("GetAssignees", err) - return - } ctx.Data["Title"] = "Comparing " + base.ShortSha(beforeCommitID) + "..." + base.ShortSha(afterCommitID) |