diff options
author | wxiaoguang <wxiaoguang@gmail.com> | 2023-02-21 21:36:53 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-02-21 21:36:53 +0800 |
commit | 1fcf96ad0166420cbdb013365ecae42e3537b42a (patch) | |
tree | 98ffceb52a082da7985f97dee42462a1805898f3 /routers | |
parent | 9ebf6424eedce94b1f5ab3ff34b41198e51e36f8 (diff) | |
download | gitea-1fcf96ad0166420cbdb013365ecae42e3537b42a.tar.gz gitea-1fcf96ad0166420cbdb013365ecae42e3537b42a.zip |
Improve PR Review Box UI (#22986)
This PR follows:
* #22950
### Before
The Review Box has many problems:
* It doesn't work for small screens.
* It has an anonying animation which makes the UI laggy.
* It uses "custom dropdown menu" which is very difficult to fine tune.
* `$().toggle('visible')` is not a correct call
* jQuery just accepts any invalid `duration` argument:
`$().toggle('anyting')`
* The button is not a button.
<details>
![image](https://user-images.githubusercontent.com/2114189/219948865-6da3f39c-6fde-4c86-9e42-da5020f3d0c3.png)
</details>
### After
These problems are fixed, and eliminate many `!important` games.
<details>
![image](https://user-images.githubusercontent.com/2114189/219952744-8862fe1a-7ef1-49e4-bf92-2d0c1f104ee4.png)
![image](https://user-images.githubusercontent.com/2114189/219952771-be169a76-45fd-47a8-8f9c-b447d064f4ca.png)
![image](https://user-images.githubusercontent.com/2114189/219952784-3f52e9b7-64ce-4ad1-9553-64c33fb83042.png)
</details>
And most dropdown icons still looks good:
<details>
![image](https://user-images.githubusercontent.com/2114189/219952942-52866a00-e0f9-4af7-8fb5-eb1a8cad1ff3.png)
![image](https://user-images.githubusercontent.com/2114189/219948909-b3bfb844-f84e-4b79-ab1f-382ec66dec31.png)
</details>
Co-authored-by: delvh <leon@kske.dev>
Diffstat (limited to 'routers')
0 files changed, 0 insertions, 0 deletions