diff options
author | Jason Song <i@wolfogre.com> | 2023-03-29 23:27:37 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-03-29 11:27:37 -0400 |
commit | 3e8db31a5b5a7be731b19da4bd666b0ddc35bd31 (patch) | |
tree | 0c51783184dcb015fda3ca03c611bd3d9476349c /services/actions/job_emitter.go | |
parent | e57e1144c5ae7a2995e6818c6ae32139e563add7 (diff) | |
download | gitea-3e8db31a5b5a7be731b19da4bd666b0ddc35bd31.tar.gz gitea-3e8db31a5b5a7be731b19da4bd666b0ddc35bd31.zip |
Refactor commit status for Actions jobs (#23786)
Before:
<img width="353" alt="xnip_230329_163852"
src="https://user-images.githubusercontent.com/9418365/228479807-424452df-10fa-45cf-ae4b-09939c0ed54c.png">
After:
<img width="508" alt="xnip_230329_163358"
src="https://user-images.githubusercontent.com/9418365/228479923-537b54fe-9564-4105-a068-bcc75fa2a7ea.png">
Highlights:
- Treat `StatusSkipped` as `CommitStatusSuccess` instead of
`CommitStatusFailure`, so it fixed #23599.
- Use the bot user `gitea-actions` instead of the trigger as the creator
of commit status.
- New format `<run_name> / <job_name> / (<event>)` for the context of
commit status to avoid conflicts.
- Add descriptions for commit status.
- Add the missing calls to `CreateCommitStatus`.
- Refactor `CreateCommitStatus` to make it easier to use.
Diffstat (limited to 'services/actions/job_emitter.go')
-rw-r--r-- | services/actions/job_emitter.go | 16 |
1 files changed, 10 insertions, 6 deletions
diff --git a/services/actions/job_emitter.go b/services/actions/job_emitter.go index cb2cc8d1ac..c6b6fc551e 100644 --- a/services/actions/job_emitter.go +++ b/services/actions/job_emitter.go @@ -45,11 +45,11 @@ func jobEmitterQueueHandle(data ...queue.Data) []queue.Data { } func checkJobsOfRun(ctx context.Context, runID int64) error { - return db.WithTx(ctx, func(ctx context.Context) error { - jobs, _, err := actions_model.FindRunJobs(ctx, actions_model.FindRunJobOptions{RunID: runID}) - if err != nil { - return err - } + jobs, _, err := actions_model.FindRunJobs(ctx, actions_model.FindRunJobOptions{RunID: runID}) + if err != nil { + return err + } + if err := db.WithTx(ctx, func(ctx context.Context) error { idToJobs := make(map[string][]*actions_model.ActionRunJob, len(jobs)) for _, job := range jobs { idToJobs[job.JobID] = append(idToJobs[job.JobID], job) @@ -67,7 +67,11 @@ func checkJobsOfRun(ctx context.Context, runID int64) error { } } return nil - }) + }); err != nil { + return err + } + CreateCommitStatus(ctx, jobs...) + return nil } type jobStatusResolver struct { |