diff options
| author | Jason Song <i@wolfogre.com> | 2023-06-22 21:08:08 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-22 13:08:08 +0000 |
| commit | 174213530dc538c124cddc5cc43d9a514c6695b9 (patch) | |
| tree | 061bdae4a57ed1ca17d1b85bb4c7ab69fe673d71 /services/actions/notifier_helper.go | |
| parent | 7fb539677b448a9cc554e71afb98da558f3e0631 (diff) | |
| download | gitea-174213530dc538c124cddc5cc43d9a514c6695b9.tar.gz gitea-174213530dc538c124cddc5cc43d9a514c6695b9.zip | |
Fix `Permission` in API returned repository struct (#25388)
The old code generates `structs.Repository.Permissions` with only
`access.Permission.AccessMode`, however, it should check the units too,
or the value could be incorrect. For example,
`structs.Repository.Permissions.Push` could be false even the doer has
write access to code unit.
Should fix
https://github.com/renovatebot/renovate/issues/14059#issuecomment-1047961128
(Not reported by it, I just found it when I was looking into this bug)
---
Review tips:
The major changes are
- `modules/structs/repo.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-870406f6857117f8b03611c43fca0ab9ed6d6e76a2d0069a7c1f17e8fa9092f7
- `services/convert/repository.go`
https://github.com/go-gitea/gitea/pull/25388/files#diff-7736f6d2ae894c9edb7729a80ab89aa183b888a26a811a0c1fdebd18726a7101
And other changes are passive.
Diffstat (limited to 'services/actions/notifier_helper.go')
| -rw-r--r-- | services/actions/notifier_helper.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/services/actions/notifier_helper.go b/services/actions/notifier_helper.go index 5e41241d18..69c23656f2 100644 --- a/services/actions/notifier_helper.go +++ b/services/actions/notifier_helper.go @@ -222,14 +222,14 @@ func notifyRelease(ctx context.Context, doer *user_model.User, rel *repo_model.R return } - mode, _ := access_model.AccessLevel(ctx, doer, rel.Repo) + permission, _ := access_model.GetUserRepoPermission(ctx, rel.Repo, doer) newNotifyInput(rel.Repo, doer, webhook_module.HookEventRelease). WithRef(git.RefNameFromTag(rel.TagName).String()). WithPayload(&api.ReleasePayload{ Action: action, Release: convert.ToRelease(ctx, rel), - Repository: convert.ToRepo(ctx, rel.Repo, mode), + Repository: convert.ToRepo(ctx, rel.Repo, permission), Sender: convert.ToUser(ctx, doer, nil), }). Notify(ctx) |