summaryrefslogtreecommitdiffstats
path: root/services/auth/interface.go
diff options
context:
space:
mode:
authorzeripath <art27@cantab.net>2022-08-28 10:43:25 +0100
committerGitHub <noreply@github.com>2022-08-28 10:43:25 +0100
commitbb0ff77e461ae080b1722701aea74010ff71e0ae (patch)
treed9550dc2f4342ca5babc4bf9191fa51aacdb922e /services/auth/interface.go
parentc21d6511a8e0084644a53a3192f45443456b9a32 (diff)
downloadgitea-bb0ff77e461ae080b1722701aea74010ff71e0ae.tar.gz
gitea-bb0ff77e461ae080b1722701aea74010ff71e0ae.zip
Share HTML template renderers and create a watcher framework (#20218)
The recovery, API, Web and package frameworks all create their own HTML Renderers. This increases the memory requirements of Gitea unnecessarily with duplicate templates being kept in memory. Further the reloading framework in dev mode for these involves locking and recompiling all of the templates on each load. This will potentially hide concurrency issues and it is inefficient. This PR stores the templates renderer in the context and stores this context in the NormalRoutes, it then creates a fsnotify.Watcher framework to watch files. The watching framework is then extended to the mailer templates which were previously not being reloaded in dev. Then the locales are simplified to a similar structure. Fix #20210 Fix #20211 Fix #20217 Signed-off-by: Andrew Thornton <art27@cantab.net>
Diffstat (limited to 'services/auth/interface.go')
-rw-r--r--services/auth/interface.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/services/auth/interface.go b/services/auth/interface.go
index a05ece2078..ecc9ad2ca6 100644
--- a/services/auth/interface.go
+++ b/services/auth/interface.go
@@ -34,7 +34,7 @@ type Method interface {
type Initializable interface {
// Init should be called exactly once before using any of the other methods,
// in order to allow the plugin to allocate necessary resources
- Init() error
+ Init(ctx context.Context) error
}
// Named represents a named thing