diff options
author | silverwind <me@silverwind.io> | 2024-04-22 13:48:42 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-04-22 11:48:42 +0000 |
commit | 74f0c84fa4245a20ce6fb87dac1faf2aeeded2a2 (patch) | |
tree | 94b0356bea5ad1cd24a523947cf001509a973be1 /services/context | |
parent | aff7b7bdd285cc1fcabea774f153886e11ae9f5d (diff) | |
download | gitea-74f0c84fa4245a20ce6fb87dac1faf2aeeded2a2.tar.gz gitea-74f0c84fa4245a20ce6fb87dac1faf2aeeded2a2.zip |
Enable more `revive` linter rules (#30608)
Noteable additions:
- `redefines-builtin-id` forbid variable names that shadow go builtins
- `empty-lines` remove unnecessary empty lines that `gofumpt` does not
remove for some reason
- `superfluous-else` eliminate more superfluous `else` branches
Rules are also sorted alphabetically and I cleaned up various parts of
`.golangci.yml`.
Diffstat (limited to 'services/context')
-rw-r--r-- | services/context/repo.go | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/services/context/repo.go b/services/context/repo.go index b17f99eb17..4836c1456c 100644 --- a/services/context/repo.go +++ b/services/context/repo.go @@ -825,7 +825,6 @@ func getRefName(ctx *Base, repo *Repository, pathType RepoRefType) string { case RepoRefBranch: ref := getRefNameFromPath(ctx, repo, path, repo.GitRepo.IsBranchExist) if len(ref) == 0 { - // check if ref is HEAD parts := strings.Split(path, "/") if parts[0] == headRefName { @@ -968,7 +967,6 @@ func RepoRefByType(refType RepoRefType, ignoreNotExistErr ...bool) func(*Context return cancel } ctx.Repo.CommitID = ctx.Repo.Commit.ID.String() - } else if refType.RefTypeIncludesTags() && ctx.Repo.GitRepo.IsTagExist(refName) { ctx.Repo.IsViewTag = true ctx.Repo.TagName = refName |