diff options
| author | Wim <wim@42.be> | 2022-06-20 12:02:49 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-06-20 12:02:49 +0200 |
| commit | cb50375e2b6abf0c79d4891e5e1ea775b9759cd2 (patch) | |
| tree | 938af0f442baf79cebd114692aff5ad6af37f987 /services/issue | |
| parent | 3289abcefc563d6ea16c1dbd19680b874a58a6d3 (diff) | |
| download | gitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.tar.gz gitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.zip | |
Add more linters to improve code readability (#19989)
Add nakedret, unconvert, wastedassign, stylecheck and nolintlint linters to improve code readability
- nakedret - https://github.com/alexkohler/nakedret - nakedret is a Go static analysis tool to find naked returns in functions greater than a specified function length.
- unconvert - https://github.com/mdempsky/unconvert - Remove unnecessary type conversions
- wastedassign - https://github.com/sanposhiho/wastedassign - wastedassign finds wasted assignment statements.
- notlintlint - Reports ill-formed or insufficient nolint directives
- stylecheck - https://staticcheck.io/docs/checks/#ST - keep style consistent
- excluded: [ST1003 - Poorly chosen identifier](https://staticcheck.io/docs/checks/#ST1003) and [ST1005 - Incorrectly formatted error string](https://staticcheck.io/docs/checks/#ST1005)
Diffstat (limited to 'services/issue')
| -rw-r--r-- | services/issue/assignee.go | 6 | ||||
| -rw-r--r-- | services/issue/issue.go | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/services/issue/assignee.go b/services/issue/assignee.go index 7c00f472dd..aefd8cff9a 100644 --- a/services/issue/assignee.go +++ b/services/issue/assignee.go @@ -59,7 +59,7 @@ func ToggleAssignee(issue *issues_model.Issue, doer *user_model.User, assigneeID notification.NotifyIssueChangeAssignee(doer, issue, assignee, removed, comment) - return + return removed, comment, err } // ReviewRequest add or remove a review request from a user for this PR, and make comment for it. @@ -78,7 +78,7 @@ func ReviewRequest(issue *issues_model.Issue, doer, reviewer *user_model.User, i notification.NotifyPullReviewRequest(doer, issue, reviewer, isAdd, comment) } - return + return comment, err } // IsValidReviewRequest Check permission for ReviewRequest @@ -262,5 +262,5 @@ func TeamReviewRequest(issue *issues_model.Issue, doer *user_model.User, reviewe notification.NotifyPullReviewRequest(doer, issue, member, isAdd, comment) } - return + return comment, err } diff --git a/services/issue/issue.go b/services/issue/issue.go index 467bc14b84..7131829b03 100644 --- a/services/issue/issue.go +++ b/services/issue/issue.go @@ -129,7 +129,7 @@ func UpdateAssignees(issue *issues_model.Issue, oneAssignee string, multipleAssi } } - return + return err } // DeleteIssue deletes an issue |