summaryrefslogtreecommitdiffstats
path: root/services/pull/review.go
diff options
context:
space:
mode:
authorDavid Svantesson <davidsvantesson@gmail.com>2019-12-04 02:08:56 +0100
committertechknowlogick <techknowlogick@gitea.io>2019-12-03 20:08:56 -0500
commitbac4b78e0908c0cb01a3842436950c7bcf793cf9 (patch)
treea3c80aebb1ca69bf6e518b881229158dccf4ddd7 /services/pull/review.go
parent6460284085b0b416d61c57d729d47e932ac05efe (diff)
downloadgitea-bac4b78e0908c0cb01a3842436950c7bcf793cf9.tar.gz
gitea-bac4b78e0908c0cb01a3842436950c7bcf793cf9.zip
Branch protection: Possibility to not use whitelist but allow anyone with write access (#9055)
* Possibility to not use whitelist but allow anyone with write access * fix existing test * rename migration function * Try to give a better name for migration step * Clear settings if higher level setting is not set * Move official reviews to db instead of counting approvals each time * migration * fix * fix migration * fix migration * Remove NOT NULL from EnableWhitelist as migration isn't possible * Fix migration, reviews are connected to issues. * Fix SQL query issues in GetReviewersByPullID. * Simplify function GetReviewersByIssueID * Handle reviewers that has been deleted * Ensure reviews for test is in a well defined order * Only clear and set official reviews when it is an approve or reject.
Diffstat (limited to 'services/pull/review.go')
-rw-r--r--services/pull/review.go1
1 files changed, 1 insertions, 0 deletions
diff --git a/services/pull/review.go b/services/pull/review.go
index e2179dd0e5..84b6256992 100644
--- a/services/pull/review.go
+++ b/services/pull/review.go
@@ -72,6 +72,7 @@ func CreateCodeComment(doer *models.User, issue *models.Issue, line int64, conte
Type: models.ReviewTypePending,
Reviewer: doer,
Issue: issue,
+ Official: false,
})
if err != nil {
return nil, err