diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2022-10-23 22:44:45 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-10-23 22:44:45 +0800 |
| commit | dcd9fc7ee894700f702f3847d7d2a41d6a009b7e (patch) | |
| tree | 76b1d6fdb2a760f3da57bbe566146d1c79ab5a87 /services/release/release.go | |
| parent | 4eeea7b30ee5d90ed4e9410ec5c7d0252ada3a3b (diff) | |
| download | gitea-dcd9fc7ee894700f702f3847d7d2a41d6a009b7e.tar.gz gitea-dcd9fc7ee894700f702f3847d7d2a41d6a009b7e.zip | |
Refactor git command arguments and make all arguments to be safe to be used (#21535)
Follow #21464
Make all git command arguments strictly safe. Most changes are one-to-one replacing, keep all existing logic.
Diffstat (limited to 'services/release/release.go')
| -rw-r--r-- | services/release/release.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/services/release/release.go b/services/release/release.go index af1b075232..25b89e1a0b 100644 --- a/services/release/release.go +++ b/services/release/release.go @@ -309,7 +309,7 @@ func DeleteReleaseByID(ctx context.Context, id int64, doer *user_model.User, del } } - if stdout, _, err := git.NewCommand(ctx, "tag", "-d", "--", rel.TagName). + if stdout, _, err := git.NewCommand(ctx, "tag", "-d").AddDashesAndList(rel.TagName). SetDescription(fmt.Sprintf("DeleteReleaseByID (git tag -d): %d", rel.ID)). RunStdString(&git.RunOpts{Dir: repo.RepoPath()}); err != nil && !strings.Contains(err.Error(), "not found") { log.Error("DeleteReleaseByID (git tag -d): %d in %v Failed:\nStdout: %s\nError: %v", rel.ID, repo, stdout, err) |