diff options
| author | TheFox0x7 <thefox0x7@gmail.com> | 2024-12-15 11:41:29 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-12-15 10:41:29 +0000 |
| commit | 33e8e82c4b528db8efb1cf9fc4dbab2d9e21ace8 (patch) | |
| tree | 6ee296e2ef469911d0db440100e1eb835945af89 /services/repository | |
| parent | df9a78cd04e364264c103cf3a92d94179cc1dd4f (diff) | |
| download | gitea-33e8e82c4b528db8efb1cf9fc4dbab2d9e21ace8.tar.gz gitea-33e8e82c4b528db8efb1cf9fc4dbab2d9e21ace8.zip | |
Enable tenv and testifylint rules (#32852)
Enables tenv and testifylint linters
closes: https://github.com/go-gitea/gitea/issues/32842
Diffstat (limited to 'services/repository')
| -rw-r--r-- | services/repository/archiver/archiver_test.go | 5 | ||||
| -rw-r--r-- | services/repository/license_test.go | 2 | ||||
| -rw-r--r-- | services/repository/transfer_test.go | 2 |
3 files changed, 4 insertions, 5 deletions
diff --git a/services/repository/archiver/archiver_test.go b/services/repository/archiver/archiver_test.go index 2ab18edf49..1d0c6e513d 100644 --- a/services/repository/archiver/archiver_test.go +++ b/services/repository/archiver/archiver_test.go @@ -4,7 +4,6 @@ package archiver import ( - "errors" "testing" "time" @@ -121,7 +120,7 @@ func TestArchive_Basic(t *testing.T) { // It's fine to go ahead and set it to nil now. assert.Equal(t, zipReq, zipReq2) - assert.False(t, zipReq == zipReq2) + assert.NotSame(t, zipReq, zipReq2) // Same commit, different compression formats should have different names. // Ideally, the extension would match what we originally requested. @@ -131,5 +130,5 @@ func TestArchive_Basic(t *testing.T) { func TestErrUnknownArchiveFormat(t *testing.T) { err := ErrUnknownArchiveFormat{RequestFormat: "master"} - assert.True(t, errors.Is(err, ErrUnknownArchiveFormat{})) + assert.ErrorIs(t, err, ErrUnknownArchiveFormat{}) } diff --git a/services/repository/license_test.go b/services/repository/license_test.go index 39e9738145..9d3e0f36e3 100644 --- a/services/repository/license_test.go +++ b/services/repository/license_test.go @@ -65,7 +65,7 @@ func Test_detectLicense(t *testing.T) { result, err := detectLicense(strings.NewReader(tests[2].arg + tests[3].arg + tests[4].arg)) assert.NoError(t, err) t.Run("multiple licenses test", func(t *testing.T) { - assert.Equal(t, 3, len(result)) + assert.Len(t, result, 3) assert.Contains(t, result, tests[2].want[0]) assert.Contains(t, result, tests[3].want[0]) assert.Contains(t, result, tests[4].want[0]) diff --git a/services/repository/transfer_test.go b/services/repository/transfer_test.go index 67799eddcc..0401701ba5 100644 --- a/services/repository/transfer_test.go +++ b/services/repository/transfer_test.go @@ -103,7 +103,7 @@ func TestRepositoryTransfer(t *testing.T) { assert.NoError(t, models.CreatePendingRepositoryTransfer(db.DefaultContext, doer, user2, repo.ID, nil)) transfer, err = models.GetPendingRepositoryTransfer(db.DefaultContext, repo) - assert.Nil(t, err) + assert.NoError(t, err) assert.NoError(t, transfer.LoadAttributes(db.DefaultContext)) assert.Equal(t, "user2", transfer.Recipient.Name) |