diff options
author | Wim <wim@42.be> | 2022-06-20 12:02:49 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-06-20 12:02:49 +0200 |
commit | cb50375e2b6abf0c79d4891e5e1ea775b9759cd2 (patch) | |
tree | 938af0f442baf79cebd114692aff5ad6af37f987 /services/webhook | |
parent | 3289abcefc563d6ea16c1dbd19680b874a58a6d3 (diff) | |
download | gitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.tar.gz gitea-cb50375e2b6abf0c79d4891e5e1ea775b9759cd2.zip |
Add more linters to improve code readability (#19989)
Add nakedret, unconvert, wastedassign, stylecheck and nolintlint linters to improve code readability
- nakedret - https://github.com/alexkohler/nakedret - nakedret is a Go static analysis tool to find naked returns in functions greater than a specified function length.
- unconvert - https://github.com/mdempsky/unconvert - Remove unnecessary type conversions
- wastedassign - https://github.com/sanposhiho/wastedassign - wastedassign finds wasted assignment statements.
- notlintlint - Reports ill-formed or insufficient nolint directives
- stylecheck - https://staticcheck.io/docs/checks/#ST - keep style consistent
- excluded: [ST1003 - Poorly chosen identifier](https://staticcheck.io/docs/checks/#ST1003) and [ST1005 - Incorrectly formatted error string](https://staticcheck.io/docs/checks/#ST1005)
Diffstat (limited to 'services/webhook')
-rw-r--r-- | services/webhook/webhook.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/services/webhook/webhook.go b/services/webhook/webhook.go index 68cfe147aa..767c3701f3 100644 --- a/services/webhook/webhook.go +++ b/services/webhook/webhook.go @@ -70,7 +70,7 @@ var webhooks = map[webhook_model.HookType]*webhook{ // RegisterWebhook registers a webhook func RegisterWebhook(name string, webhook *webhook) { - webhooks[webhook_model.HookType(name)] = webhook + webhooks[name] = webhook } // IsValidHookTaskType returns true if a webhook registered @@ -78,7 +78,7 @@ func IsValidHookTaskType(name string) bool { if name == webhook_model.GITEA || name == webhook_model.GOGS { return true } - _, ok := webhooks[webhook_model.HookType(name)] + _, ok := webhooks[name] return ok } |