diff options
| author | JakobDev <jakobdev@gmx.de> | 2023-05-25 15:17:19 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-25 15:17:19 +0200 |
| commit | aaa109466350c531b9238a61115b2877daca57d3 (patch) | |
| tree | 4f5759d3591d6424d80e44e5b8ee97bdd0c7c9ac /services | |
| parent | 79087bdb2676ac383f4bd21137d4454f7a26c8c4 (diff) | |
| download | gitea-aaa109466350c531b9238a61115b2877daca57d3.tar.gz gitea-aaa109466350c531b9238a61115b2877daca57d3.zip | |
Add the ability to pin Issues (#24406)
This adds the ability to pin important Issues and Pull Requests. You can
also move pinned Issues around to change their Position. Resolves #2175.
## Screenshots
The Design was mostly copied from the Projects Board.
## Implementation
This uses a new `pin_order` Column in the `issue` table. If the value is
set to 0, the Issue is not pinned. If it's set to a bigger value, the
value is the Position. 1 means it's the first pinned Issue, 2 means it's
the second one etc. This is dived into Issues and Pull requests for each
Repo.
## TODO
- [x] You can currently pin as many Issues as you want. Maybe we should
add a Limit, which is configurable. GitHub uses 3, but I prefer 6, as
this is better for bigger Projects, but I'm open for suggestions.
- [x] Pin and Unpin events need to be added to the Issue history.
- [x] Tests
- [x] Migration
**The feature itself is currently fully working, so tester who may find
weird edge cases are very welcome!**
---------
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Giteabot <teabot@gitea.io>
Diffstat (limited to 'services')
| -rw-r--r-- | services/convert/issue.go | 1 | ||||
| -rw-r--r-- | services/convert/pull.go | 1 | ||||
| -rw-r--r-- | services/issue/issue.go | 7 |
3 files changed, 9 insertions, 0 deletions
diff --git a/services/convert/issue.go b/services/convert/issue.go index 3d1b21c6bf..bcb1618e8f 100644 --- a/services/convert/issue.go +++ b/services/convert/issue.go @@ -47,6 +47,7 @@ func ToAPIIssue(ctx context.Context, issue *issues_model.Issue) *api.Issue { Comments: issue.NumComments, Created: issue.CreatedUnix.AsTime(), Updated: issue.UpdatedUnix.AsTime(), + PinOrder: issue.PinOrder, } if issue.Repo != nil { diff --git a/services/convert/pull.go b/services/convert/pull.go index 598187ca6e..1ac0f4e96f 100644 --- a/services/convert/pull.go +++ b/services/convert/pull.go @@ -72,6 +72,7 @@ func ToAPIPullRequest(ctx context.Context, pr *issues_model.PullRequest, doer *u Deadline: apiIssue.Deadline, Created: pr.Issue.CreatedUnix.AsTimePtr(), Updated: pr.Issue.UpdatedUnix.AsTimePtr(), + PinOrder: apiIssue.PinOrder, AllowMaintainerEdit: pr.AllowMaintainerEdit, diff --git a/services/issue/issue.go b/services/issue/issue.go index d4f827e99a..06da47152c 100644 --- a/services/issue/issue.go +++ b/services/issue/issue.go @@ -153,6 +153,13 @@ func DeleteIssue(ctx context.Context, doer *user_model.User, gitRepo *git.Reposi } } + // If the Issue is pinned, we should unpin it before deletion to avoid problems with other pinned Issues + if issue.IsPinned() { + if err := issue.Unpin(ctx, doer); err != nil { + return err + } + } + notification.NotifyDeleteIssue(ctx, doer, issue) return nil |