diff options
| author | Giteabot <teabot@gitea.io> | 2023-07-29 22:47:46 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-07-29 14:47:46 +0000 |
| commit | c5fe09db726e2b97b646446976c0968cb0ddd1d5 (patch) | |
| tree | 16789356df567e0885810cde372d577eb486183a /services | |
| parent | 09814117e3a7505fca75dd747c6d0d886bc1467e (diff) | |
| download | gitea-c5fe09db726e2b97b646446976c0968cb0ddd1d5.tar.gz gitea-c5fe09db726e2b97b646446976c0968cb0ddd1d5.zip | |
Warn instead of reporting an error when a webhook cannot be found (#26039) (#26211)
Backport #26039 by @puni9869
Attemp fix: #25744
Fixing the log level when we delete any repo then we get error hook not
found by id. That should be warn level to reduce the noise in the logs.
Co-authored-by: puni9869 <80308335+puni9869@users.noreply.github.com>
Diffstat (limited to 'services')
| -rw-r--r-- | services/webhook/webhook.go | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/services/webhook/webhook.go b/services/webhook/webhook.go index 3cd9deafd8..9d5dab85f7 100644 --- a/services/webhook/webhook.go +++ b/services/webhook/webhook.go @@ -5,6 +5,7 @@ package webhook import ( "context" + "errors" "fmt" "strings" @@ -111,7 +112,11 @@ func handler(items ...int64) []int64 { for _, taskID := range items { task, err := webhook_model.GetHookTaskByID(ctx, taskID) if err != nil { - log.Error("GetHookTaskByID[%d] failed: %v", taskID, err) + if errors.Is(err, util.ErrNotExist) { + log.Warn("GetHookTaskByID[%d] warn: %v", taskID, err) + } else { + log.Error("GetHookTaskByID[%d] failed: %v", taskID, err) + } continue } |