diff options
author | Jason Song <i@wolfogre.com> | 2024-09-11 13:47:00 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2024-09-11 05:47:00 +0000 |
commit | 125679f2e14cdc8a26a147f7e8fd0e5f174fb5cb (patch) | |
tree | 0844fc3e7bcc8969f190b8e1f44ed62891823116 /services | |
parent | def1c9670b5f8d5cc967bea61255fb3935dd5f50 (diff) | |
download | gitea-125679f2e14cdc8a26a147f7e8fd0e5f174fb5cb.tar.gz gitea-125679f2e14cdc8a26a147f7e8fd0e5f174fb5cb.zip |
Support allowed hosts for migrations to work with proxy (#32025)
Diffstat (limited to 'services')
-rw-r--r-- | services/migrations/http_client.go | 2 | ||||
-rw-r--r-- | services/migrations/migrate.go | 4 | ||||
-rw-r--r-- | services/webhook/deliver.go | 2 |
3 files changed, 2 insertions, 6 deletions
diff --git a/services/migrations/http_client.go b/services/migrations/http_client.go index 9e3caec191..0b997e08f4 100644 --- a/services/migrations/http_client.go +++ b/services/migrations/http_client.go @@ -24,6 +24,6 @@ func NewMigrationHTTPTransport() *http.Transport { return &http.Transport{ TLSClientConfig: &tls.Config{InsecureSkipVerify: setting.Migrations.SkipTLSVerify}, Proxy: proxy.Proxy(), - DialContext: hostmatcher.NewDialContext("migration", allowList, blockList), + DialContext: hostmatcher.NewDialContext("migration", allowList, blockList, setting.Proxy.ProxyURLFixed), } } diff --git a/services/migrations/migrate.go b/services/migrations/migrate.go index 21bdc68e73..d0ad6d0139 100644 --- a/services/migrations/migrate.go +++ b/services/migrations/migrate.go @@ -499,9 +499,5 @@ func Init() error { // TODO: at the moment, if ALLOW_LOCALNETWORKS=false, ALLOWED_DOMAINS=domain.com, and domain.com has IP 127.0.0.1, then it's still allowed. // if we want to block such case, the private&loopback should be added to the blockList when ALLOW_LOCALNETWORKS=false - if setting.Proxy.Enabled && setting.Proxy.ProxyURLFixed != nil { - allowList.AppendPattern(setting.Proxy.ProxyURLFixed.Host) - } - return nil } diff --git a/services/webhook/deliver.go b/services/webhook/deliver.go index b2c0a73784..4707602cdf 100644 --- a/services/webhook/deliver.go +++ b/services/webhook/deliver.go @@ -303,7 +303,7 @@ func Init() error { Transport: &http.Transport{ TLSClientConfig: &tls.Config{InsecureSkipVerify: setting.Webhook.SkipTLSVerify}, Proxy: webhookProxy(allowedHostMatcher), - DialContext: hostmatcher.NewDialContextWithProxy("webhook", allowedHostMatcher, nil, setting.Webhook.ProxyURLFixed), + DialContext: hostmatcher.NewDialContext("webhook", allowedHostMatcher, nil, setting.Webhook.ProxyURLFixed), }, } |