summaryrefslogtreecommitdiffstats
path: root/services
diff options
context:
space:
mode:
authorLunny Xiao <xiaolunwen@gmail.com>2020-01-15 11:14:50 +0800
committerAntoine GIRARD <sapk@users.noreply.github.com>2020-01-15 04:14:50 +0100
commitd32eac44b16c7b3320b586f402621de84fafa185 (patch)
tree8d41d16dbfc266cdf910ab146d338b442990d27d /services
parentfd761708feb9d19ec7e387e0313336d2e5893987 (diff)
downloadgitea-d32eac44b16c7b3320b586f402621de84fafa185.tar.gz
gitea-d32eac44b16c7b3320b586f402621de84fafa185.zip
Move RepoWorkingPool to services/repository package (#9754)
* Move RepoWorkingPool to services/repository package * Make repoWorkingPool private Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com>
Diffstat (limited to 'services')
-rw-r--r--services/repository/transfer.go16
1 files changed, 10 insertions, 6 deletions
diff --git a/services/repository/transfer.go b/services/repository/transfer.go
index 9b3c084eab..978a966c41 100644
--- a/services/repository/transfer.go
+++ b/services/repository/transfer.go
@@ -7,10 +7,14 @@ package repository
import (
"code.gitea.io/gitea/models"
"code.gitea.io/gitea/modules/notification"
+ "code.gitea.io/gitea/modules/sync"
"github.com/unknwon/com"
)
+// repoWorkingPool represents a working pool to order the parallel changes to the same repository
+var repoWorkingPool = sync.NewExclusivePool()
+
// TransferOwnership transfers all corresponding setting from old user to new one.
func TransferOwnership(doer *models.User, newOwnerName string, repo *models.Repository) error {
if err := repo.GetOwner(); err != nil {
@@ -19,12 +23,12 @@ func TransferOwnership(doer *models.User, newOwnerName string, repo *models.Repo
oldOwner := repo.Owner
- models.RepoWorkingPool.CheckIn(com.ToStr(repo.ID))
+ repoWorkingPool.CheckIn(com.ToStr(repo.ID))
if err := models.TransferOwnership(doer, newOwnerName, repo); err != nil {
- models.RepoWorkingPool.CheckOut(com.ToStr(repo.ID))
+ repoWorkingPool.CheckOut(com.ToStr(repo.ID))
return err
}
- models.RepoWorkingPool.CheckOut(com.ToStr(repo.ID))
+ repoWorkingPool.CheckOut(com.ToStr(repo.ID))
notification.NotifyTransferRepository(doer, repo, oldOwner.Name)
@@ -39,12 +43,12 @@ func ChangeRepositoryName(doer *models.User, repo *models.Repository, newRepoNam
// repo so that we can atomically rename the repo path and updates the
// local copy's origin accordingly.
- models.RepoWorkingPool.CheckIn(com.ToStr(repo.ID))
+ repoWorkingPool.CheckIn(com.ToStr(repo.ID))
if err := models.ChangeRepositoryName(doer, repo, newRepoName); err != nil {
- models.RepoWorkingPool.CheckOut(com.ToStr(repo.ID))
+ repoWorkingPool.CheckOut(com.ToStr(repo.ID))
return err
}
- models.RepoWorkingPool.CheckOut(com.ToStr(repo.ID))
+ repoWorkingPool.CheckOut(com.ToStr(repo.ID))
notification.NotifyRenameRepository(doer, repo, oldRepoName)