summaryrefslogtreecommitdiffstats
path: root/services
diff options
context:
space:
mode:
authorzeripath <art27@cantab.net>2020-02-17 20:22:36 +0000
committerGitHub <noreply@github.com>2020-02-17 20:22:36 +0000
commite96f3542d02d42686c505544cdc8e9638d6befd8 (patch)
tree1275ff33b7fb08b9e339629af245051f26792f93 /services
parent314740e215fa2d4a0a375095ce0a7c484af56ebb (diff)
downloadgitea-e96f3542d02d42686c505544cdc8e9638d6befd8.tar.gz
gitea-e96f3542d02d42686c505544cdc8e9638d6befd8.zip
Set the initial commit status to Success otherwise it will always be Pending (#10317)
The commit status code has a bug whereby setting the initial status to Pending means you can never have the status of Success - it should be set to Success.
Diffstat (limited to 'services')
-rw-r--r--services/pull/commit_status.go2
1 files changed, 1 insertions, 1 deletions
diff --git a/services/pull/commit_status.go b/services/pull/commit_status.go
index 3dccfb1f0c..77aca48556 100644
--- a/services/pull/commit_status.go
+++ b/services/pull/commit_status.go
@@ -23,7 +23,7 @@ func MergeRequiredContextsCommitStatus(commitStatuses []*models.CommitStatus, re
return structs.CommitStatusSuccess
}
- var returnedStatus = structs.CommitStatusPending
+ var returnedStatus = structs.CommitStatusSuccess
for _, ctx := range requiredContexts {
var targetStatus structs.CommitStatusState
for _, commitStatus := range commitStatuses {