diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-04-10 16:44:02 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-10 16:44:02 +0800 |
| commit | 4e3348135723dfc03dcc91b196b5da6f20b8a4ea (patch) | |
| tree | 8734e1d537d93243dd6ba478b9f2890cc8ac0d89 /services | |
| parent | bb6c670cff1a081d9f5f8bdb3dc91abe5d9e35b9 (diff) | |
| download | gitea-4e3348135723dfc03dcc91b196b5da6f20b8a4ea.tar.gz gitea-4e3348135723dfc03dcc91b196b5da6f20b8a4ea.zip | |
Make label templates have consistent behavior and priority (#23749)
Fix https://github.com/go-gitea/gitea/issues/23715
Other related PRs:
* #23717
* #23716
* #23719
This PR is different from others, it tries to resolve the problem fundamentally (and brings more benefits)
Although it looks like some more lines are added, actually many new lines are for tests.
----
Before, the code was just "guessing" the file type and try to parse them.
<details>
</details>
This PR:
* Always remember the original option file names, and always use correct parser for them.
* Another benefit is that we can sort the Label Templates now (before there was a map, its key order is undefined)
Diffstat (limited to 'services')
| -rw-r--r-- | services/repository/repository.go | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/services/repository/repository.go b/services/repository/repository.go index 000b1a3da6..0d6529383c 100644 --- a/services/repository/repository.go +++ b/services/repository/repository.go @@ -81,7 +81,9 @@ func PushCreateRepo(ctx context.Context, authUser, owner *user_model.User, repoN // Init start repository service func Init() error { - repo_module.LoadRepoConfig() + if err := repo_module.LoadRepoConfig(); err != nil { + return err + } system_model.RemoveAllWithNotice(db.DefaultContext, "Clean up temporary repository uploads", setting.Repository.Upload.TempPath) system_model.RemoveAllWithNotice(db.DefaultContext, "Clean up temporary repositories", repo_module.LocalCopyPath()) return initPushQueue() |