diff options
| author | Eng Zer Jun <engzerjun@gmail.com> | 2023-10-06 14:49:37 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-10-06 14:49:37 +0800 |
| commit | 13d5d2e7110ca643d8ca1c7655e2a4ff89fe5b8d (patch) | |
| tree | baba009364130ebb8d458669e97a592bb2804a43 /services | |
| parent | 6cdeb7798ba7dc1e9d7ea7e181d51f845951b905 (diff) | |
| download | gitea-13d5d2e7110ca643d8ca1c7655e2a4ff89fe5b8d.tar.gz gitea-13d5d2e7110ca643d8ca1c7655e2a4ff89fe5b8d.zip | |
Remove redundant `len` check around loop (#27464)
This pull request is a minor code cleanup.
From the Go specification (https://go.dev/ref/spec#For_range):
> "1. For a nil slice, the number of iterations is 0."
> "3. If the map is nil, the number of iterations is 0."
`len` returns 0 if the slice or map is nil
(https://pkg.go.dev/builtin#len). Therefore, checking `len(v) > 0`
before a loop is unnecessary.
---
At the time of writing this pull request, there wasn't a lint rule that
catches these issues. The closest I could find is
https://staticcheck.dev/docs/checks/#S103
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Diffstat (limited to 'services')
| -rw-r--r-- | services/pull/pull.go | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/services/pull/pull.go b/services/pull/pull.go index 5e76fac815..8ef7499ad5 100644 --- a/services/pull/pull.go +++ b/services/pull/pull.go @@ -152,14 +152,12 @@ func NewPullRequest(ctx context.Context, repo *repo_model.Repository, issue *iss if issue.Milestone != nil { notify_service.IssueChangeMilestone(ctx, issue.Poster, issue, 0) } - if len(assigneeIDs) > 0 { - for _, assigneeID := range assigneeIDs { - assignee, err := user_model.GetUserByID(ctx, assigneeID) - if err != nil { - return ErrDependenciesLeft - } - notify_service.IssueChangeAssignee(ctx, issue.Poster, issue, assignee, false, assigneeCommentMap[assigneeID]) + for _, assigneeID := range assigneeIDs { + assignee, err := user_model.GetUserByID(ctx, assigneeID) + if err != nil { + return ErrDependenciesLeft } + notify_service.IssueChangeAssignee(ctx, issue.Poster, issue, assignee, false, assigneeCommentMap[assigneeID]) } return nil |