summaryrefslogtreecommitdiffstats
path: root/templates/repo/diff/section_code.tmpl
diff options
context:
space:
mode:
authorsilverwind <me@silverwind.io>2023-06-14 20:17:58 +0200
committerGitHub <noreply@github.com>2023-06-14 18:17:58 +0000
commite24f651c86a5168da8181f2c75f5f99b56561224 (patch)
tree1f604dc894e29a0c99adca856bd55ad1ca78d4be /templates/repo/diff/section_code.tmpl
parenta0eaf0881235d41ca98f4718af815908d1237d2c (diff)
downloadgitea-e24f651c86a5168da8181f2c75f5f99b56561224.tar.gz
gitea-e24f651c86a5168da8181f2c75f5f99b56561224.zip
Add template linting via djlint (#25212)
So I found this [linter](https://github.com/Riverside-Healthcare/djlint) which features a mode for go templates, so I gave it a try and it did find a number of valid issue, like unbalanced tags etc. It also has a number of bugs, I had to disable/workaround many issues. Given that this linter is written in python, this does add a dependency on `python` >= 3.8 and `poetry` to the development environment to be able to run this linter locally. - `e.g.` prefixes on placeholders are removed because the linter had a false-positive on `placeholder="e.g. cn=Search"` for the `attr=value` syntax and it's not ideal anyways to write `e.g.` into a placeholder because a placeholder is meant to hold a sample value. - In `templates/repo/settings/options.tmpl` I simplified the logic to not conditionally create opening tags without closing tags because this stuff confuses the linter (and possibly the reader as well).
Diffstat (limited to 'templates/repo/diff/section_code.tmpl')
-rw-r--r--templates/repo/diff/section_code.tmpl7
1 files changed, 1 insertions, 6 deletions
diff --git a/templates/repo/diff/section_code.tmpl b/templates/repo/diff/section_code.tmpl
index c95ce83fc4..3e8303eda6 100644
--- a/templates/repo/diff/section_code.tmpl
+++ b/templates/repo/diff/section_code.tmpl
@@ -1,6 +1 @@
-<code {{if .diff.EscapeStatus.Escaped}}{{/*
- */}}class="code-inner has-escaped" {{/*
- */}}title="{{template "repo/diff/escape_title" .}}"{{/*
- */}}{{else}}{{/*
- */}}class="code-inner"{{/*
- */}}{{end}}>{{.diff.Content}}</code>
+<code class="code-inner{{if .diff.EscapeStatus.Escaped}} has-escaped{{end}}"{{if .diff.EscapeStatus.Escaped}} title="{{template "repo/diff/escape_title" .}}"{{end}}>{{.diff.Content}}</code>