diff options
author | wxiaoguang <wxiaoguang@gmail.com> | 2023-03-23 11:24:16 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-03-23 11:24:16 +0800 |
commit | 389e83f7eb68c43f6f0313b20acde547aef12442 (patch) | |
tree | 08edb4fa00247fb394e7f065614f9fb7f55336f4 /templates/repo/empty.tmpl | |
parent | 1d35fa0e784dffcadacb2322a3d7ac3ec2ff89b2 (diff) | |
download | gitea-389e83f7eb68c43f6f0313b20acde547aef12442.tar.gz gitea-389e83f7eb68c43f6f0313b20acde547aef12442.zip |
Improve `<SvgIcon>` to make it output `svg` node and optimize performance (#23570)
Before, the Vue `<SvgIcon>` always outputs DOM nodes like:
```html
<span class="outer-class">
<svg class="class-name-defined" ...></svg>
</span>
```
The `span` is redundant and I guess such layout and the inconsistent
`class/class-name` attributes would cause bugs sooner or later.
This PR makes the `<SvgIcon>` clear, and it's faster than before,
because it doesn't need to parse the whole SVG string.
Before:
<details>
![image](https://user-images.githubusercontent.com/2114189/226156474-ce2c57cd-b869-486a-b75b-1eebdac8cdf7.png)
</details>
After:
![image](https://user-images.githubusercontent.com/2114189/226155774-108f49ed-7512-40c3-94a2-a6e8da18063d.png)
---------
Co-authored-by: silverwind <me@silverwind.io>
Diffstat (limited to 'templates/repo/empty.tmpl')
0 files changed, 0 insertions, 0 deletions