diff options
author | silverwind <me@silverwind.io> | 2020-10-05 07:49:33 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-10-05 01:49:33 -0400 |
commit | cda44750cbdc7a8460666a4f0ac7f652d84a3964 (patch) | |
tree | 207745d1b529a0cde5207111d23bfc07c1e0312c /templates/repo/issue/view_content.tmpl | |
parent | 67a5573310cf23726e3c2ef4651221c6dc150075 (diff) | |
download | gitea-cda44750cbdc7a8460666a4f0ac7f652d84a3964.tar.gz gitea-cda44750cbdc7a8460666a4f0ac7f652d84a3964.zip |
Attachments: Add extension support, allow all types for releases (#12465)
* Attachments: Add extension support, allow all types for releases
- Add support for file extensions, matching the `accept` attribute of `<input type="file">`
- Add support for type wildcard mime types, e.g. `image/*`
- Create repository.release.ALLOWED_TYPES setting (default unrestricted)
- Change default for attachment.ALLOWED_TYPES to a list of extensions
- Split out POST /attachments into two endpoints for issue/pr and
releases to prevent circumvention of allowed types check
Fixes: https://github.com/go-gitea/gitea/pull/10172
Fixes: https://github.com/go-gitea/gitea/issues/7266
Fixes: https://github.com/go-gitea/gitea/pull/12460
Ref: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file#Unique_file_type_specifiers
* rename function
* extract GET routes out of RepoMustNotBeArchived
Co-authored-by: Lauris BH <lauris@nix.lv>
Diffstat (limited to 'templates/repo/issue/view_content.tmpl')
-rw-r--r-- | templates/repo/issue/view_content.tmpl | 15 |
1 files changed, 3 insertions, 12 deletions
diff --git a/templates/repo/issue/view_content.tmpl b/templates/repo/issue/view_content.tmpl index 1addbaf5bb..a4ce0a7106 100644 --- a/templates/repo/issue/view_content.tmpl +++ b/templates/repo/issue/view_content.tmpl @@ -197,19 +197,10 @@ </div> </div> {{if .IsAttachmentEnabled}} - <div class="field"> - <div class="comment-files"></div> - <div class="ui dropzone" id="comment-dropzone" - data-upload-url="{{AppSubUrl}}/attachments" - data-remove-url="{{AppSubUrl}}/attachments/delete" - data-csrf="{{.CsrfToken}}" data-accepts="{{.AttachmentAllowedTypes}}" - data-max-file="{{.AttachmentMaxFiles}}" data-max-size="{{.AttachmentMaxSize}}" - data-default-message="{{.i18n.Tr "dropzone.default_message"}}" - data-invalid-input-type="{{.i18n.Tr "dropzone.invalid_input_type"}}" - data-file-too-big="{{.i18n.Tr "dropzone.file_too_big"}}" - data-remove-file="{{.i18n.Tr "dropzone.remove_file"}}"> + <div class="field"> + <div class="comment-files"></div> + {{template "repo/upload" .}} </div> - </div> {{end}} <div class="field footer"> <div class="text right edit"> |