diff options
author | yp05327 <576951401@qq.com> | 2023-05-23 06:26:48 +0900 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-05-22 21:26:48 +0000 |
commit | 5c0745c0349f0709d0fc36fd8a97dcab86bce28a (patch) | |
tree | b183263d0c4fb1105f5b39a98060112c7e06f7f2 /templates/repo/issue | |
parent | 81ce271f783331682e07594a179444077b240c84 (diff) | |
download | gitea-5c0745c0349f0709d0fc36fd8a97dcab86bce28a.tar.gz gitea-5c0745c0349f0709d0fc36fd8a97dcab86bce28a.zip |
Add validations.required check to dropdown field (#24849)
If dropdown is marked as required, we should not provide the `remove`
button.
This will cause user may post empty value which seems like a bug.
Definition:
![image](https://github.com/go-gitea/gitea/assets/18380374/cf48b478-244e-44e0-9a0e-7a0f02bc471a)
Post request form:
![image](https://github.com/go-gitea/gitea/assets/18380374/31d6f823-835f-422a-879c-3b1e18950ac8)
Result:
![image](https://github.com/go-gitea/gitea/assets/18380374/a9944fe9-24d0-4776-9eec-d31b70144eb4)
Diffstat (limited to 'templates/repo/issue')
-rw-r--r-- | templates/repo/issue/fields/dropdown.tmpl | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/templates/repo/issue/fields/dropdown.tmpl b/templates/repo/issue/fields/dropdown.tmpl index 28e5d27e33..23aa373cd2 100644 --- a/templates/repo/issue/fields/dropdown.tmpl +++ b/templates/repo/issue/fields/dropdown.tmpl @@ -4,7 +4,9 @@ <div class="ui fluid selection dropdown {{if .item.Attributes.multiple}}multiple clearable{{end}}"> <input type="hidden" name="form-field-{{.item.ID}}" value="0"> {{svg "octicon-triangle-down" 14 "dropdown icon"}} + {{if not .item.Validations.required}} {{svg "octicon-x" 14 "remove icon"}} + {{end}} <div class="default text"></div> <div class="menu"> {{range $i, $opt := .item.Attributes.options}} |