diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-03-23 11:24:16 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-23 11:24:16 +0800 |
| commit | 389e83f7eb68c43f6f0313b20acde547aef12442 (patch) | |
| tree | 08edb4fa00247fb394e7f065614f9fb7f55336f4 /templates/repo/projects | |
| parent | 1d35fa0e784dffcadacb2322a3d7ac3ec2ff89b2 (diff) | |
| download | gitea-389e83f7eb68c43f6f0313b20acde547aef12442.tar.gz gitea-389e83f7eb68c43f6f0313b20acde547aef12442.zip | |
Improve `<SvgIcon>` to make it output `svg` node and optimize performance (#23570)
Before, the Vue `<SvgIcon>` always outputs DOM nodes like:
```html
<span class="outer-class">
<svg class="class-name-defined" ...></svg>
</span>
```
The `span` is redundant and I guess such layout and the inconsistent
`class/class-name` attributes would cause bugs sooner or later.
This PR makes the `<SvgIcon>` clear, and it's faster than before,
because it doesn't need to parse the whole SVG string.
Before:
<details>
</details>
After:
---------
Co-authored-by: silverwind <me@silverwind.io>
Diffstat (limited to 'templates/repo/projects')
| -rw-r--r-- | templates/repo/projects/view.tmpl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl index 0248b9c6d2..99831f3dd9 100644 --- a/templates/repo/projects/view.tmpl +++ b/templates/repo/projects/view.tmpl @@ -235,7 +235,7 @@ {{- range index $.LinkedPRs .ID}} <div class="meta gt-my-2"> <a href="{{$.RepoLink}}/pulls/{{.Index}}"> - <span class="gt-m-0 {{if .PullRequest.HasMerged}}purple{{else if .IsClosed}}red{{else}}green{{end}}">{{svg "octicon-git-merge" 16 "gt-mr-2 gt-vm"}}</span> + <span class="gt-m-0 text {{if .PullRequest.HasMerged}}purple{{else if .IsClosed}}red{{else}}green{{end}}">{{svg "octicon-git-merge" 16 "gt-mr-2 gt-vm"}}</span> <span class="gt-vm">{{.Title}} <span class="text light grey">#{{.Index}}</span></span> </a> </div> |