diff options
author | wxiaoguang <wxiaoguang@gmail.com> | 2023-04-17 11:37:23 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-04-17 11:37:23 +0800 |
commit | 7681d582cdae42d9322309ddf732117e6d332776 (patch) | |
tree | 6cdfa61a2055f23153884404fe93d4b4792fd532 /templates/repo/release/new.tmpl | |
parent | be7cd73439c2210bfd889915f74d66686e99dab6 (diff) | |
download | gitea-7681d582cdae42d9322309ddf732117e6d332776.tar.gz gitea-7681d582cdae42d9322309ddf732117e6d332776.zip |
Refactor locale number (#24134)
Before, the `GiteaLocaleNumber.js` was just written as a a drop-in
replacement for old `js-pretty-number`.
Actually, we can use Golang's `text` package to format.
This PR partially completes the TODOs in `GiteaLocaleNumber.js`:
> if we have complete backend locale support (eg: Golang "x/text"
package), we can drop this component.
> tooltip: only 2 usages of this, we can replace it with Golang's
"x/text/number" package in the future.
This PR also helps #24131
Screenshots:
<details>
![image](https://user-images.githubusercontent.com/2114189/232179420-b1b9974b-9d96-4408-b209-b80182c8b359.png)
![image](https://user-images.githubusercontent.com/2114189/232179416-14f36aa0-3f3e-4ac9-b366-7bd3a4464a11.png)
</details>
Diffstat (limited to 'templates/repo/release/new.tmpl')
-rw-r--r-- | templates/repo/release/new.tmpl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/templates/repo/release/new.tmpl b/templates/repo/release/new.tmpl index 7a4e28cffa..ddedfd6086 100644 --- a/templates/repo/release/new.tmpl +++ b/templates/repo/release/new.tmpl @@ -71,9 +71,9 @@ <input name="attachment-edit-{{.UUID}}" class="gt-mr-3 attachment_edit" required value="{{.Name}}"> <input name="attachment-del-{{.UUID}}" type="hidden" value="false"> <span class="ui text grey gt-mr-3">{{.Size | FileSize}}</span> - <gitea-locale-number data-number-in-tooltip="{{dict "message" ($.locale.Tr "repo.release.download_count") "number" .DownloadCount | Json}}"> + <span data-tooltip-content="{{$.locale.Tr "repo.release.download_count" ($.locale.PrettyNumber .DownloadCount)}}"> {{svg "octicon-info"}} - </gitea-locale-number> + </span> </div> </div> {{end}} |