diff options
| author | yp05327 <576951401@qq.com> | 2023-06-08 17:52:35 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-08 08:52:35 +0000 |
| commit | b5a2bb9ab347fb5aaa6c6ca95dfd1b31751f1fba (patch) | |
| tree | ed441b2c2b854d54797b0113dea0bde54bda6010 /templates/repo | |
| parent | 679b1f7949aa40d4f962ef27f91b0b384b9c56a5 (diff) | |
| download | gitea-b5a2bb9ab347fb5aaa6c6ca95dfd1b31751f1fba.tar.gz gitea-b5a2bb9ab347fb5aaa6c6ca95dfd1b31751f1fba.zip | |
Fix strange UI behavior of cancelling dismiss review modal (#25133)
Fixes https://github.com/go-gitea/gitea/issues/25130
The old code uses `$(this).next()` to get `dismiss-review-modal`.
At first, it will get `$(#dismiss-review-modal)`, but the next time it
will get `$(#dismiss-review-modal).next();`
and then `$(#dismiss-review-modal).next().next();`.
Because div `dismiss-review-modal` will be removed when
`dismiss-review-btn` clicked.
Maybe the right usage is adding `show-modal` class and `data-modal`
attribute.
Diffstat (limited to 'templates/repo')
| -rw-r--r-- | templates/repo/issue/view_content/sidebar.tmpl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/templates/repo/issue/view_content/sidebar.tmpl b/templates/repo/issue/view_content/sidebar.tmpl index ebb844bc00..a053fec066 100644 --- a/templates/repo/issue/view_content/sidebar.tmpl +++ b/templates/repo/issue/view_content/sidebar.tmpl @@ -58,10 +58,10 @@ </div> <div class="gt-df gt-ac gt-gap-3"> {{if (and $.Permission.IsAdmin (or (eq .Review.Type 1) (eq .Review.Type 3)) (not $.Issue.IsClosed))}} - <a href="#" class="ui muted icon gt-df gt-ac dismiss-review-btn" data-review-id="dismiss-review-{{.Review.ID}}" data-tooltip-content="{{$.locale.Tr "repo.issues.dismiss_review"}}"> + <a href="#" class="ui muted icon gt-df gt-ac show-modal" data-review-id="dismiss-review-{{.Review.ID}}" data-tooltip-content="{{$.locale.Tr "repo.issues.dismiss_review"}}" data-modal="#dismiss-review-modal"> {{svg "octicon-x" 20}} </a> - <div class="ui small modal" id="dismiss-review-modal"> + <div class="ui small modal dismiss-review-modal" id="dismiss-review-modal"> <div class="header"> {{$.locale.Tr "repo.issues.dismiss_review"}} </div> |