diff options
| author | silverwind <me@silverwind.io> | 2021-11-22 09:19:01 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-11-22 16:19:01 +0800 |
| commit | a159c3175f5f60a9de00f4d3c73787ffa6c63ddd (patch) | |
| tree | db212e3f9d20eb26bba12774ff3d8fa0bac71cbc /templates/repo | |
| parent | 7743f13bed7dc5958c19603ccadd095db24c6b80 (diff) | |
| download | gitea-a159c3175f5f60a9de00f4d3c73787ffa6c63ddd.tar.gz gitea-a159c3175f5f60a9de00f4d3c73787ffa6c63ddd.zip | |
Add new JS linter rules (#17699)
* Add new JS linter rules
Adds a few useful rules from eslint-plugin-github. Notable changes:
- Forbid dataset usage, its camel-casing behaviour makes it hard to
grep for attributes.
- Forbid .then() and .catch(), we should generally prefer await for new
code. For rare cases where they are useful, a eslint-disable-line
directive can be set.
- Add docs js to linting
* also enable github/array-foreach
* small tweak
Co-authored-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Diffstat (limited to 'templates/repo')
| -rw-r--r-- | templates/repo/clone_buttons.tmpl | 2 | ||||
| -rw-r--r-- | templates/repo/empty.tmpl | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/templates/repo/clone_buttons.tmpl b/templates/repo/clone_buttons.tmpl index 218eb31cb6..29d3fe76d7 100644 --- a/templates/repo/clone_buttons.tmpl +++ b/templates/repo/clone_buttons.tmpl @@ -24,7 +24,7 @@ const sshButton = document.getElementById('repo-clone-ssh'); const httpsButton = document.getElementById('repo-clone-https'); const input = document.getElementById('repo-clone-url'); - if (input) input.value = (isSSH ? sshButton : httpsButton).dataset.link; + if (input) input.value = (isSSH ? sshButton : httpsButton).getAttribute('data-link'); if (sshButton) sshButton.classList[isSSH ? 'add' : 'remove']('primary'); if (httpsButton) httpsButton.classList[isSSH ? 'remove' : 'add']('primary'); setTimeout(() => { diff --git a/templates/repo/empty.tmpl b/templates/repo/empty.tmpl index 485a6aa4e5..20563f59e6 100644 --- a/templates/repo/empty.tmpl +++ b/templates/repo/empty.tmpl @@ -51,7 +51,7 @@ git push -u origin {{.Repository.DefaultBranch}}</code></pre> const cloneUrls = document.getElementsByClassName('clone-url'); if (cloneUrls) { for (let i = 0; i < cloneUrls.length; i++) { - cloneUrls[i].textContent = (isSSH ? sshButton : httpsButton).dataset.link; + cloneUrls[i].textContent = (isSSH ? sshButton : httpsButton).getAttribute('data-link'); } } </script> |