diff options
author | Hester Gong <hestergong@gmail.com> | 2023-04-07 08:11:02 +0800 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-04-07 08:11:02 +0800 |
commit | 6eb678374b583079a0a08b7ed0c9ca220c0c0434 (patch) | |
tree | 9b06ba9c77a39b611b3e5ade32d77081449d0058 /templates/shared | |
parent | 08f4a9cca22d2c092760fb83dbaa1bf0c9dbb49e (diff) | |
download | gitea-6eb678374b583079a0a08b7ed0c9ca220c0c0434.tar.gz gitea-6eb678374b583079a0a08b7ed0c9ca220c0c0434.zip |
Refactor authors dropdown (send get request from frontend to avoid long wait time) (#23890)
Right now the authors search dropdown might take a long time to load if
amount of authors is huge.
Example: (In the video below, there are about 10000 authors, and it
takes about 10 seconds to open the author dropdown)
https://user-images.githubusercontent.com/17645053/229422229-98aa9656-3439-4f8c-9f4e-83bd8e2a2557.mov
Possible improvements can be made, which will take 2 steps (Thanks to
@wolfogre for advice):
Step 1:
Backend: Add a new api, which returns a limit of 30 posters with matched
prefix.
Frontend: Change the search behavior from frontend search(fomantic
search) to backend search(when input is changed, send a request to get
authors matching the current search prefix)
Step 2:
Backend: Optimize the api in step 1 using indexer to support fuzzy
search.
This PR is implements the first step. The main changes:
1. Added api: `GET /{type:issues|pulls}/posters` , which return a limit
of 30 users with matched prefix (prefix sent as query). If
`DEFAULT_SHOW_FULL_NAME` in `custom/conf/app.ini` is set to true, will
also include fullnames fuzzy search.
2. Added a tooltip saying "Shows a maximum of 30 users" to the author
search dropdown
3. Change the search behavior from frontend search to backend search
After:
https://user-images.githubusercontent.com/17645053/229430960-f88fafd8-fd5d-4f84-9df2-2677539d5d08.mov
Fixes: https://github.com/go-gitea/gitea/issues/22586
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Diffstat (limited to 'templates/shared')
0 files changed, 0 insertions, 0 deletions