diff options
| author | Yarden Shoham <git@yardenshoham.com> | 2024-01-30 16:45:54 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-01-30 15:45:54 +0100 |
| commit | 3e8414179c3f3e8a12d3a66fdf32c144f941f5c3 (patch) | |
| tree | be2f951dd05c75badcc18540274bc553b210b1bb /templates/shared | |
| parent | 27d4c11ec3bd1658c07d0bb9b0b7f3712aafb0bb (diff) | |
| download | gitea-3e8414179c3f3e8a12d3a66fdf32c144f941f5c3.tar.gz gitea-3e8414179c3f3e8a12d3a66fdf32c144f941f5c3.zip | |
Introduce htmx and use it to avoid full page load on `Subscribe` and `Follow` (#28908)
- Closes https://github.com/go-gitea/gitea/issues/28880
This change introduces htmx with the hope we could use it to make Gitea
more reactive while keeping our "HTML rendered on the server" approach.
- Add `htmx.js` that imports `htmx.org` and initializes error toasts
- Place `hx-headers='{"x-csrf-token": "{{.CsrfToken}}"}'` on the
`<body>` tag so every request that htmx sends is authenticated
- Place `hx-swap="outerHTML"` on the `<body>` tag so the response of
each htmx request replaces the tag it targets (as opposed to its inner
content)
- Place `hx-push-url="false"` on the `<body>` tag so no changes to the
URL happen in `<form>` tags
- Add the `is-loading` class during request
### Error toasts in action
## Don't do a full page load when clicking the subscribe button
- Refactor the form around the subscribe button into its own template
- Use htmx to perform the form submission
- `hx-boost="true"` to prevent the default form submission behavior of a
full page load
- `hx-sync="this:replace"` to replace the current request (in case the
button is clicked again before the response is returned)
- `hx-target="this"` to replace the form tag with the new form tag
- Change the backend response to return a `<form>` tag instead of a
redirect to the issue page
### Before
### After
## Don't do a full page load when clicking the follow button
- Use htmx to perform the button request
- `hx-post="{{.ContextUser.HomeLink}}?action=follow"` to send a POST
request to follow the user
- `hx-target="#profile-avatar-card"` to target the card div for
replacement
- `hx-indicator="#profile-avatar-card"` to place the loading indicator
on the card
- Change the backend response to return a `<div>` tag (the card) instead
of a redirect to the user page
### Before
### After
---------
Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: 6543 <m.huber@kithara.com>
Co-authored-by: Giteabot <teabot@gitea.io>
Diffstat (limited to 'templates/shared')
| -rw-r--r-- | templates/shared/user/profile_big_avatar.tmpl | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/templates/shared/user/profile_big_avatar.tmpl b/templates/shared/user/profile_big_avatar.tmpl index a637a9a5f9..4fbc43f541 100644 --- a/templates/shared/user/profile_big_avatar.tmpl +++ b/templates/shared/user/profile_big_avatar.tmpl @@ -1,4 +1,4 @@ -<div class="ui card"> +<div id="profile-avatar-card" class="ui card"> <div id="profile-avatar" class="content gt-df"> {{if eq .SignedUserID .ContextUser.ID}} <a class="image" href="{{AppSubUrl}}/user/settings" data-tooltip-content="{{ctx.Locale.Tr "user.change_avatar"}}"> @@ -110,13 +110,13 @@ </li> {{end}} {{if and .IsSigned (ne .SignedUserID .ContextUser.ID)}} - <li class="follow"> + <li class="follow" hx-target="#profile-avatar-card" hx-indicator="#profile-avatar-card" > {{if $.IsFollowing}} - <button class="ui basic red button link-action" data-url="{{.ContextUser.HomeLink}}?action=unfollow"> + <button hx-post="{{.ContextUser.HomeLink}}?action=unfollow" class="ui basic red button"> {{svg "octicon-person"}} {{ctx.Locale.Tr "user.unfollow"}} </button> {{else}} - <button class="ui basic primary button link-action" data-url="{{.ContextUser.HomeLink}}?action=follow"> + <button hx-post="{{.ContextUser.HomeLink}}?action=follow" class="ui basic primary button"> {{svg "octicon-person"}} {{ctx.Locale.Tr "user.follow"}} </button> {{end}} |