diff options
| author | silverwind <me@silverwind.io> | 2023-06-14 20:17:58 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-14 18:17:58 +0000 |
| commit | e24f651c86a5168da8181f2c75f5f99b56561224 (patch) | |
| tree | 1f604dc894e29a0c99adca856bd55ad1ca78d4be /templates/status | |
| parent | a0eaf0881235d41ca98f4718af815908d1237d2c (diff) | |
| download | gitea-e24f651c86a5168da8181f2c75f5f99b56561224.tar.gz gitea-e24f651c86a5168da8181f2c75f5f99b56561224.zip | |
Add template linting via djlint (#25212)
So I found this [linter](https://github.com/Riverside-Healthcare/djlint)
which features a mode for go templates, so I gave it a try and it did
find a number of valid issue, like unbalanced tags etc. It also has a
number of bugs, I had to disable/workaround many issues.
Given that this linter is written in python, this does add a dependency
on `python` >= 3.8 and `poetry` to the development environment to be
able to run this linter locally.
- `e.g.` prefixes on placeholders are removed because the linter had a
false-positive on `placeholder="e.g. cn=Search"` for the `attr=value`
syntax and it's not ideal anyways to write `e.g.` into a placeholder
because a placeholder is meant to hold a sample value.
- In `templates/repo/settings/options.tmpl` I simplified the logic to
not conditionally create opening tags without closing tags because this
stuff confuses the linter (and possibly the reader as well).
Diffstat (limited to 'templates/status')
| -rw-r--r-- | templates/status/404.tmpl | 2 | ||||
| -rw-r--r-- | templates/status/500.tmpl | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/templates/status/404.tmpl b/templates/status/404.tmpl index a55e2fbad9..5d0ea4df28 100644 --- a/templates/status/404.tmpl +++ b/templates/status/404.tmpl @@ -5,7 +5,7 @@ <p style="margin-top: 100px"><img src="{{AssetUrlPrefix}}/img/404.png" alt="404"></p> <div class="ui divider"></div> <br> - <p>{{.locale.Tr "error404" | Safe}} + <p>{{.locale.Tr "error404" | Safe}}</p> {{if .ShowFooterVersion}}<p>{{.locale.Tr "admin.config.app_ver"}}: {{AppVer}}</p>{{end}} </div> </div> diff --git a/templates/status/500.tmpl b/templates/status/500.tmpl index b934910fe4..06b999e423 100644 --- a/templates/status/500.tmpl +++ b/templates/status/500.tmpl @@ -37,7 +37,7 @@ {{end}} <div class="center gt-mt-5"> {{if or .SignedUser.IsAdmin .ShowFooterVersion}}<p>{{.locale.Tr "admin.config.app_ver"}}: {{AppVer}}</p>{{end}} - {{if .SignedUser.IsAdmin}}<p>{{.locale.Tr "error.report_message" | Str2html}}</p>{{end}} + {{if .SignedUser.IsAdmin}}<p>{{.locale.Tr "error.report_message" | Str2html}}</p>{{end}} </div> </div> </div> |