diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-04-30 23:51:20 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-30 11:51:20 -0400 |
| commit | 14c142b0bca2af79f30fcf221479fb66d63dbdf8 (patch) | |
| tree | 9262eade4d2e21210cd66618468d99162a66707b /templates/user/notification | |
| parent | e8173c2c33f1dd5b0a2c044255434d414cab62d2 (diff) | |
| download | gitea-14c142b0bca2af79f30fcf221479fb66d63dbdf8.tar.gz gitea-14c142b0bca2af79f30fcf221479fb66d63dbdf8.zip | |
Improve issue list filter (#24425)
Partial regression of #24393, not only regression, but broken for long
time, 24393 didn't really improve it but used wrong `overflow: scroll`.
Actually, that "ui secondary filter menu labels" shouldn't be set as
scrollable (I missed that at that time), the problem is: if a "ui menu"
has "dropdown" items, then it should not be scrollable. Otherwise the
dropdown menu can't be shown correctly.
And there are more problems:
* The "issue-filters" shouldn't be used anywhere else (copying&pasting
problem again ....)
* There is also an "issue-actions" container, it should also be fixed.
* There are similar problems on the milestone page.
* The old comment in code: "grid column" doesn't work well.
The major changes of this PR are: use "flex: 1" instead of "ui grid
column".
After this PR, not 100% perfect but much better than before.
Diffstat (limited to 'templates/user/notification')
| -rw-r--r-- | templates/user/notification/notification_subscriptions.tmpl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/templates/user/notification/notification_subscriptions.tmpl b/templates/user/notification/notification_subscriptions.tmpl index ce46919236..6d3262ad6d 100644 --- a/templates/user/notification/notification_subscriptions.tmpl +++ b/templates/user/notification/notification_subscriptions.tmpl @@ -11,7 +11,7 @@ </div> <div class="ui bottom attached active tab segment"> {{if eq .Status 1}} - <div id="issue-filters" class="ui stackable grid"> + <div class="ui stackable grid"> <div class="six wide column"> <div class="small-pill-buttons ui compact tiny menu"> <a class="{{if eq .State "all"}}active {{end}}item" href="{{$.Link}}?sort={{$.SortType}}&state=all&issueType={{$.IssueType}}&labels={{$.Labels}}"> |