diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2024-03-01 15:11:51 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2024-03-01 07:11:51 +0000 |
| commit | e71eb8930a5d0f60874b038c223498b41ad65592 (patch) | |
| tree | f95ac2c5ed1854929ef63dddeddf8720963477f5 /templates/user | |
| parent | 58ce1de994c2a036ebf7137c143ce193694d740d (diff) | |
| download | gitea-e71eb8930a5d0f60874b038c223498b41ad65592.tar.gz gitea-e71eb8930a5d0f60874b038c223498b41ad65592.zip | |
Refactor some Str2html code (#29397)
This PR touches the most interesting part of the "template refactoring".
1. Unclear variable type. Especially for "web/feed/convert.go":
sometimes it uses text, sometimes it uses HTML.
2. Assign text content to "RenderedContent" field, for example: `
project.RenderedContent = project.Description` in web/org/projects.go
3. Assign rendered content to text field, for example: `r.Note =
rendered content` in web/repo/release.go
4. (possible) Incorrectly calling `{{Str2html
.PackageDescriptor.Metadata.ReleaseNotes}}` in
package/content/nuget.tmpl, I guess the name Str2html misleads
developers to use it to "render string to html", but it only sanitizes.
if ReleaseNotes really contains HTML, then this is not a problem.
Diffstat (limited to 'templates/user')
| -rw-r--r-- | templates/user/dashboard/milestones.tmpl | 2 | ||||
| -rw-r--r-- | templates/user/profile.tmpl | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/templates/user/dashboard/milestones.tmpl b/templates/user/dashboard/milestones.tmpl index 1829021ff4..737a0f7e2b 100644 --- a/templates/user/dashboard/milestones.tmpl +++ b/templates/user/dashboard/milestones.tmpl @@ -141,7 +141,7 @@ </div> {{if .Content}} <div class="markup content"> - {{.RenderedContent|Str2html}} + {{.RenderedContent}} </div> {{end}} </li> diff --git a/templates/user/profile.tmpl b/templates/user/profile.tmpl index 426b5f042a..37590fc2fa 100644 --- a/templates/user/profile.tmpl +++ b/templates/user/profile.tmpl @@ -29,7 +29,7 @@ {{else if eq .TabName "followers"}} {{template "repo/user_cards" .}} {{else if eq .TabName "overview"}} - <div id="readme_profile" class="markup">{{.ProfileReadme | Str2html}}</div> + <div id="readme_profile" class="markup">{{.ProfileReadme}}</div> {{else}} {{template "explore/repo_search" .}} {{template "explore/repo_list" .}} |