diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2021-12-10 10:51:27 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-12-10 10:51:27 +0800 |
| commit | 0a9fcf63a49799ad3b0f146c54879161bac61e10 (patch) | |
| tree | e4a6382fc1a2de403f2fec47886348dae5e72d2b /templates | |
| parent | 719bddcd76610a63dadc8555760072957a11cf30 (diff) | |
| download | gitea-0a9fcf63a49799ad3b0f146c54879161bac61e10.tar.gz gitea-0a9fcf63a49799ad3b0f146c54879161bac61e10.zip | |
Clean legacy SimpleMDE code (#17926)
Since we are using EasyMDE now, we do not need to keep the SimpleMDE code anymore.
This PR removes all legacy SimpleMDE code, and makes some related changes:
* `createCommentEasyMDE` can accept native DOM element, and it doesn't need `jQuery.data` to store EasyMDE editor object (as discussed about the frontend guideline).
* introduce `getAttachedEasyMDE` to get the attached EasyMDE editor object, it's easier to find all the usage of EasyMDE.
* rename variable names from `$simplemde` to `easyMDE`, the `$` was incorrect because it is a EasyMDE editor, not a jQuery object.
With this PR, it will be easier to do more refactoring or replacing EasyMDE with other editors.
Diffstat (limited to 'templates')
| -rw-r--r-- | templates/base/footer.tmpl | 2 | ||||
| -rw-r--r-- | templates/base/head.tmpl | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/templates/base/footer.tmpl b/templates/base/footer.tmpl index ead5630dae..2b641cc9de 100644 --- a/templates/base/footer.tmpl +++ b/templates/base/footer.tmpl @@ -12,7 +12,7 @@ {{template "custom/body_outer_post" .}} {{template "base/footer_content" .}} -{{if .RequireSimpleMDE}} +{{if .RequireEasyMDE}} <script src="{{AssetUrlPrefix}}/js/easymde.js?v={{MD5 AppVer}}"></script> <script src="{{AssetUrlPrefix}}/vendor/plugins/codemirror/addon/mode/loadmode.js"></script> <script src="{{AssetUrlPrefix}}/vendor/plugins/codemirror/mode/meta.js"></script> diff --git a/templates/base/head.tmpl b/templates/base/head.tmpl index dd8e68761b..e9c2d512df 100644 --- a/templates/base/head.tmpl +++ b/templates/base/head.tmpl @@ -56,7 +56,7 @@ </script> <link rel="icon" href="{{AssetUrlPrefix}}/img/logo.svg" type="image/svg+xml"> <link rel="alternate icon" href="{{AssetUrlPrefix}}/img/favicon.png" type="image/png"> -{{if .RequireSimpleMDE}} +{{if .RequireEasyMDE}} <link rel="stylesheet" href="{{AssetUrlPrefix}}/css/easymde.css?v={{MD5 AppVer}}"> {{end}} <link rel="stylesheet" href="{{AssetUrlPrefix}}/css/index.css?v={{MD5 AppVer}}"> |