diff options
| author | Dan Church <h3xx@users.noreply.github.com> | 2023-04-23 09:28:27 -0500 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-23 10:28:27 -0400 |
| commit | 67da4c1b259e9d000535f35974cf12051c1c42b5 (patch) | |
| tree | fa253d23def011b6763a78b0c366d1d4c8cccfe3 /templates | |
| parent | b3e849d1d65799ed08565f56b6356f346e23013f (diff) | |
| download | gitea-67da4c1b259e9d000535f35974cf12051c1c42b5.tar.gz gitea-67da4c1b259e9d000535f35974cf12051c1c42b5.zip | |
Set type="password" on all auth_token fields (#22175)
Set `type="password"` on all `auth_token` fields
Seen when migrating from other hosting platforms.
1. Prevents exposing the token to screen capture/cameras/eyeballs.
2. Prevents the browser from saving the value in its autocomplete
dictionary, which often is not secure.
Closes #22174
---------
Signed-off-by: Dan Church <amphetamachine@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Diffstat (limited to 'templates')
| -rw-r--r-- | templates/repo/migrate/gitea.tmpl | 2 | ||||
| -rw-r--r-- | templates/repo/migrate/github.tmpl | 2 | ||||
| -rw-r--r-- | templates/repo/migrate/gitlab.tmpl | 2 | ||||
| -rw-r--r-- | templates/repo/migrate/gogs.tmpl | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/templates/repo/migrate/gitea.tmpl b/templates/repo/migrate/gitea.tmpl index ecbf89608e..f1d4e4f06b 100644 --- a/templates/repo/migrate/gitea.tmpl +++ b/templates/repo/migrate/gitea.tmpl @@ -20,7 +20,7 @@ <div class="inline field {{if .Err_Auth}}error{{end}}"> <label for="auth_token">{{.locale.Tr "access_token"}}</label> - <input id="auth_token" name="auth_token" value="{{.auth_token}}" {{if not .auth_token}} data-need-clear="true" {{end}}> + <input id="auth_token" name="auth_token" type="password" autocomplete="new-password" value="{{.auth_token}}" {{if not .auth_token}} data-need-clear="true" {{end}}> <a target="_blank" href="https://docs.gitea.io/en-us/api-usage">{{svg "octicon-question"}}</a> </div> diff --git a/templates/repo/migrate/github.tmpl b/templates/repo/migrate/github.tmpl index 63b5e83a2c..c591f2a465 100644 --- a/templates/repo/migrate/github.tmpl +++ b/templates/repo/migrate/github.tmpl @@ -20,7 +20,7 @@ <div class="inline field {{if .Err_Auth}}error{{end}}"> <label for="auth_token">{{.locale.Tr "access_token"}}</label> - <input id="auth_token" name="auth_token" value="{{.auth_token}}" {{if not .auth_token}}data-need-clear="true"{{end}}> + <input id="auth_token" name="auth_token" type="password" autocomplete="new-password" value="{{.auth_token}}" {{if not .auth_token}}data-need-clear="true"{{end}}> <a target="_blank" href="https://docs.github.com/en/github/authenticating-to-github/creating-a-personal-access-token">{{svg "octicon-question"}}</a> <span class="help"> {{.locale.Tr "repo.migrate.github_token_desc"}} diff --git a/templates/repo/migrate/gitlab.tmpl b/templates/repo/migrate/gitlab.tmpl index 946b7da37a..65559da152 100644 --- a/templates/repo/migrate/gitlab.tmpl +++ b/templates/repo/migrate/gitlab.tmpl @@ -20,7 +20,7 @@ <div class="inline field {{if .Err_Auth}}error{{end}}"> <label for="auth_token">{{.locale.Tr "access_token"}}</label> - <input id="auth_token" name="auth_token" value="{{.auth_token}}" {{if not .auth_token}}data-need-clear="true"{{end}}> + <input id="auth_token" name="auth_token" type="password" autocomplete="new-password" value="{{.auth_token}}" {{if not .auth_token}}data-need-clear="true"{{end}}> <a target="_blank" href="https://docs.gitlab.com/ee/user/profile/personal_access_tokens.html">{{svg "octicon-question"}}</a> </div> diff --git a/templates/repo/migrate/gogs.tmpl b/templates/repo/migrate/gogs.tmpl index 85dbce8164..8bc57861ad 100644 --- a/templates/repo/migrate/gogs.tmpl +++ b/templates/repo/migrate/gogs.tmpl @@ -20,7 +20,7 @@ <div class="inline field {{if .Err_Auth}}error{{end}}"> <label for="auth_token">{{.locale.Tr "access_token"}}</label> - <input id="auth_token" name="auth_token" value="{{.auth_token}}" {{if not .auth_token}} data-need-clear="true" {{end}}> + <input id="auth_token" name="auth_token" type="password" autocomplete="new-password" value="{{.auth_token}}" {{if not .auth_token}} data-need-clear="true" {{end}}> <!-- <a target="_blank" href="https://docs.gitea.io/en-us/api-usage">{{svg "octicon-question"}}</a> --> </div> |