aboutsummaryrefslogtreecommitdiffstats
path: root/templates
diff options
context:
space:
mode:
authoroliverpool <3864879+oliverpool@users.noreply.github.com>2023-02-20 09:43:04 +0100
committerGitHub <noreply@github.com>2023-02-20 16:43:04 +0800
commit3596df52c09831f7f39f8416264ff267954f35a0 (patch)
treee4234049f1337eb98db3325804b0a5ebc4b61cab /templates
parent1d64eafe8f296e77c59c18fcda428d2b5df67ac0 (diff)
downloadgitea-3596df52c09831f7f39f8416264ff267954f35a0.tar.gz
gitea-3596df52c09831f7f39f8416264ff267954f35a0.zip
Fix hidden commit status on multiple checks (#22889)
Since #22632, when a commit status has multiple checks, no check is shown at all (hence no way to see the other checks). This PR fixes this by always adding a tag with the `.commit-statuses-trigger` to the DOM (the `.vm` is for vertical alignment). ![2023-02-13-120528](https://user-images.githubusercontent.com/3864879/218441846-1a79c169-2efd-46bb-9e75-d8b45d7cc8e3.png) --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Diffstat (limited to 'templates')
-rw-r--r--templates/repo/commit_statuses.tmpl16
1 files changed, 12 insertions, 4 deletions
diff --git a/templates/repo/commit_statuses.tmpl b/templates/repo/commit_statuses.tmpl
index 8250a85817..8858fb8402 100644
--- a/templates/repo/commit_statuses.tmpl
+++ b/templates/repo/commit_statuses.tmpl
@@ -1,6 +1,14 @@
-{{if eq (len .Statuses) 1}}{{$status := index .Statuses 0}}{{if $status.TargetURL}}<a class="ui link commit-statuses-trigger gt-vm" href="{{$status.TargetURL}}">{{template "repo/commit_status" .Status}}</a>{{end}}{{end}}
-<div class="ui commit-statuses-popup commit-statuses tippy-target">
- <div class="ui relaxed list divided">
+{{if .Statuses}}
+ {{if and (eq (len .Statuses) 1) .Status.TargetURL}}
+ <a class="gt-vm gt-tdn" data-tippy="commit-statuses" href="{{.Status.TargetURL}}">
+ {{template "repo/commit_status" .Status}}
+ </a>
+ {{else}}
+ <span class="gt-vm" data-tippy="commit-statuses" tabindex="0">
+ {{template "repo/commit_status" .Status}}
+ </span>
+ {{end}}
+ <div class="tippy-target ui relaxed list divided">
{{range .Statuses}}
<div class="ui item singular-status gt-df">
{{template "repo/commit_status" .}}
@@ -11,4 +19,4 @@
</div>
{{end}}
</div>
-</div>
+{{end}}