diff options
| author | silverwind <me@silverwind.io> | 2023-03-30 17:02:47 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-30 11:02:47 -0400 |
| commit | 525b7382d31079333dbffba625af1c0e177546db (patch) | |
| tree | 1958a54d500b9e0a997f7d10d518568c0e3da036 /templates | |
| parent | 964a057a76793c32c81394505e2f480a4bf40d0d (diff) | |
| download | gitea-525b7382d31079333dbffba625af1c0e177546db.tar.gz gitea-525b7382d31079333dbffba625af1c0e177546db.zip | |
Convert issue list checkboxes to native (#23596)
Use native instead of fomantic checkboxes in issue list. Benefits
include no more JS pop-in on load and perfect a11y.
Before, with JS pop-in:
<img width="92" alt="Screenshot 2023-03-20 at 17 02 02"
src="https://user-images.githubusercontent.com/115237/226398955-99029a1c-1150-449c-821b-e4165e7446a8.png">
After, Firefox on macOS:
<img width="126" alt="Screenshot 2023-03-20 at 17 01 26"
src="https://user-images.githubusercontent.com/115237/226399018-58df2c32-c2b2-4c78-b7df-7b76523abe21.png">
After, Chrome on macOS:
<img width="79" alt="Screenshot 2023-03-20 at 17 01 42"
src="https://user-images.githubusercontent.com/115237/226399074-947e6279-8dc3-42c2-90b5-b106c471b23d.png">
I opted to not do styling yet but I see that the inconsistency between
browsers may already be reason enough on doing it. I think if we style
them, there should be one global style, including markdown ones which
currently have custom styling.
Diffstat (limited to 'templates')
| -rw-r--r-- | templates/repo/issue/list.tmpl | 4 | ||||
| -rw-r--r-- | templates/shared/issuelist.tmpl | 6 |
2 files changed, 3 insertions, 7 deletions
diff --git a/templates/repo/issue/list.tmpl b/templates/repo/issue/list.tmpl index 38ed3873ba..c8d186bbfb 100644 --- a/templates/repo/issue/list.tmpl +++ b/templates/repo/issue/list.tmpl @@ -29,9 +29,7 @@ <div id="issue-filters" class="ui stackable grid"> <div class="six wide column"> {{if $.CanWriteIssuesOrPulls}} - <div class="ui checkbox issue-checkbox-all gt-vm"> - <input type="checkbox" title="{{.locale.Tr "repo.issues.action_check_all"}}"> - </div> + <input type="checkbox" autocomplete="off" class="issue-checkbox-all gt-vm gt-mr-4" title="{{.locale.Tr "repo.issues.action_check_all"}}"> {{end}} {{template "repo/issue/openclose" .}} </div> diff --git a/templates/shared/issuelist.tmpl b/templates/shared/issuelist.tmpl index 24fa236bb4..35994fc435 100644 --- a/templates/shared/issuelist.tmpl +++ b/templates/shared/issuelist.tmpl @@ -2,11 +2,9 @@ {{$approvalCounts := .ApprovalCounts}} {{range .Issues}} <li class="item gt-df gt-py-3"> - <div class="issue-item-left gt-df"> + <div class="issue-item-left gt-df gt-items-start"> {{if $.CanWriteIssuesOrPulls}} - <div class="ui checkbox issue-checkbox"> - <input type="checkbox" data-issue-id={{.ID}} title="{{$.locale.Tr "repo.issues.action_check"}} «{{.Title}}»"> - </div> + <input type="checkbox" autocomplete="off" class="issue-checkbox gt-mt-2 gt-mr-4" data-issue-id={{.ID}} aria-label="{{$.locale.Tr "repo.issues.action_check"}} "{{.Title}}""> {{end}} <div class="issue-item-icon"> {{if .IsPull}} |