diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-05-14 02:59:11 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-13 20:59:11 +0200 |
| commit | 82224c54e0488738dbd3b7eccf56ab08b6790627 (patch) | |
| tree | ba45f57d31a49186952afefb8448842656921026 /templates | |
| parent | 9f1d377b87771ce2ef76caeef0aa649e768a24d7 (diff) | |
| download | gitea-82224c54e0488738dbd3b7eccf56ab08b6790627.tar.gz gitea-82224c54e0488738dbd3b7eccf56ab08b6790627.zip | |
Improve avatar uploading / resizing / compressing, remove Fomantic card module (#24653)
Fixes: #8972
Fixes: #24263
And I think it also (partially) fix #24263 (no need to convert) ,
because users could upload any supported image format if it isn't larger
than AVATAR_MAX_ORIGIN_SIZE
The main idea:
* if the uploaded file size is not larger than AVATAR_MAX_ORIGIN_SIZE,
use the origin
* if the resized size is larger than the origin, use the origin
Screenshots:
JPG:
<details>
</details>
APNG:
<details>
</details>
WebP (animated)
<details>
</details>
The only exception: if a WebP image is larger than MaxOriginSize and it
is animated, then current `webp` package can't decode it, so only in
this case it isn't supported. IMO no need to support such case: why a
user would upload a 1MB animated webp as avatar? crazy .....
---------
Co-authored-by: silverwind <me@silverwind.io>
Diffstat (limited to 'templates')
| -rw-r--r-- | templates/user/profile.tmpl | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/templates/user/profile.tmpl b/templates/user/profile.tmpl index 08e50fd0ce..8d172a7d02 100644 --- a/templates/user/profile.tmpl +++ b/templates/user/profile.tmpl @@ -7,11 +7,12 @@ <div id="profile-avatar" class="content gt-df"> {{if eq .SignedUserID .ContextUser.ID}} <a class="image" href="{{AppSubUrl}}/user/settings" data-tooltip-content="{{.locale.Tr "user.change_avatar"}}"> - {{avatar $.Context .ContextUser 290}} + {{/* the size doesn't take affect (and no need to take affect), image size(width) should be controlled by the parent container since this is not a flex layout*/}} + {{avatar $.Context .ContextUser 256}} </a> {{else}} <span class="image"> - {{avatar $.Context .ContextUser 290}} + {{avatar $.Context .ContextUser 256}} </span> {{end}} </div> |