diff options
| author | wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf <61180606+wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf@users.noreply.github.com> | 2021-03-16 16:42:25 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-03-16 15:42:25 +0000 |
| commit | d2dc182dcda4cadd3da0d1fc032f392f94b3ec7b (patch) | |
| tree | e6b1aead0b0d68f8c8eb168f6ff78a45012bd9f1 /templates | |
| parent | ab70b2f4e4be3fb48a7f6a7081ac70f301aa18aa (diff) | |
| download | gitea-d2dc182dcda4cadd3da0d1fc032f392f94b3ec7b.tar.gz gitea-d2dc182dcda4cadd3da0d1fc032f392f94b3ec7b.zip | |
fix: {show,link to} proper PR on kanban board ref (#15004)
the issue was that PR references in kanban boards were being generated
using `.ID` instead of `.Index`, which led to constructing incorrect
links to possibly non-existent {PR,issue}s and following that to showing
nonsensical values in the boards.
kudos also go to @zeripath for pointing at the file to fix.
Signed-off-by: wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf <a_mirre@utb.cz>
Co-authored-by: zeripath <art27@cantab.net>
Diffstat (limited to 'templates')
| -rw-r--r-- | templates/repo/projects/view.tmpl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/templates/repo/projects/view.tmpl b/templates/repo/projects/view.tmpl index de1fc37b03..1d4a26837e 100644 --- a/templates/repo/projects/view.tmpl +++ b/templates/repo/projects/view.tmpl @@ -175,9 +175,9 @@ {{- end }} {{- range index $.LinkedPRs .ID }} <div class="meta"> - <a href="{{$.RepoLink}}/pulls/{{ .ID }}"> + <a href="{{$.RepoLink}}/pulls/{{ .Index }}"> <span class="{{if .PullRequest.HasMerged}}purple{{else if .IsClosed}}red{{else}}green{{end}}">{{svg "octicon-git-merge"}}</span> - {{ .Title}} (#{{ .ID }}) + {{ .Title}} (#{{ .Index }}) </a> </div> {{- end }} |