diff options
| author | Giteabot <teabot@gitea.io> | 2023-06-13 08:42:25 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-06-13 12:42:25 +0000 |
| commit | 3ea544d89cebdf1c6874857281370497538ac335 (patch) | |
| tree | 6704377840bedf0221ca310323af07c71836cfe5 /templates | |
| parent | 9cef7a4600d96220fb46817bb2efc9f7b7c4a58f (diff) | |
| download | gitea-3ea544d89cebdf1c6874857281370497538ac335.tar.gz gitea-3ea544d89cebdf1c6874857281370497538ac335.zip | |
Change access token UI to select dropdowns (#25109) (#25230)
Backport #25109 by @jtran
The current UI to create API access tokens uses checkboxes that have a
complicated relationship where some need to be checked and/or disabled
in certain states. It also requires that a user interact with it to
understand what their options really are.
This branch changes to use `<select>`s. It better fits the available
options, and it's closer to [GitHub's
UI](https://github.com/settings/personal-access-tokens/new), which is
good, in my opinion. It's more mobile friendly since the tap-areas are
larger. If we ever add more permissions, like Maintainer, there's a
natural place that doesn't take up more screen real-estate.
This branch also fixes a few minor issues:
- Hide the error about selecting at least one permission after second
submission
- Fix help description to call it "authorization" since that's what
permissions are about (not authentication)
Related: #24767.
<img width="883" alt="Screenshot 2023-06-07 at 5 07 34 PM"
src="https://github.com/go-gitea/gitea/assets/10803/6b63d807-c9be-4a4b-8e53-ecab6cbb8f76">
---
When it's open:
<img width="881" alt="Screenshot 2023-06-07 at 5 07 59 PM"
src="https://github.com/go-gitea/gitea/assets/10803/2432c6d0-39c2-4ca4-820e-c878ffdbfb69">
Co-authored-by: Jonathan Tran <jon@allspice.io>
Diffstat (limited to 'templates')
| -rw-r--r-- | templates/user/settings/applications.tmpl | 23 |
1 files changed, 10 insertions, 13 deletions
diff --git a/templates/user/settings/applications.tmpl b/templates/user/settings/applications.tmpl index 2b7db82dae..b889f9c0cb 100644 --- a/templates/user/settings/applications.tmpl +++ b/templates/user/settings/applications.tmpl @@ -69,20 +69,17 @@ <summary class="gt-pb-4 gt-pl-2"> {{.locale.Tr "settings.select_permissions"}} </summary> - <div class="activity meta"> - <i>{{$.locale.Tr "settings.scoped_token_desc" (printf `href="/api/swagger" target="_blank"`) (printf `href="https://docs.gitea.com/development/oauth2-provider#scopes" target="_blank"`) | Str2html}}</i> + <p class="activity meta"> + <i>{{$.locale.Tr "settings.access_token_desc" (printf `href="/api/swagger" target="_blank"`) (printf `href="https://docs.gitea.com/development/oauth2-provider#scopes" target="_blank"`) | Str2html}}</i> + </p> + <div class="scoped-access-token-mount"> + <scoped-access-token-selector + :is-admin="{{if .IsAdmin}}true{{else}}false{{end}}" + no-access-label="{{.locale.Tr "settings.permission_no_access"}}" + read-label="{{.locale.Tr "settings.permission_read"}}" + write-label="{{.locale.Tr "settings.permission_write"}}" + ></scoped-access-token-selector> </div> - <scoped-access-token-category category="activitypub"></scoped-access-token-category> - {{if .IsAdmin}} - <scoped-access-token-category category="admin"></scoped-access-token-category> - {{end}} - <scoped-access-token-category category="issue"></scoped-access-token-category> - <scoped-access-token-category category="misc"></scoped-access-token-category> - <scoped-access-token-category category="notification"></scoped-access-token-category> - <scoped-access-token-category category="organization"></scoped-access-token-category> - <scoped-access-token-category category="package"></scoped-access-token-category> - <scoped-access-token-category category="repository"></scoped-access-token-category> - <scoped-access-token-category category="user"></scoped-access-token-category> </details> <div id="scoped-access-warning" class="ui warning message center gt-db gt-hidden"> {{.locale.Tr "settings.at_least_one_permission"}} |