diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-04-26 10:53:44 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-25 22:53:44 -0400 |
| commit | 59d060622d375c4123ea88e2fa6c4f34d4fea4d3 (patch) | |
| tree | 9cde11b2504d11e9b0332dffd0230678c1745227 /tests/integration/pull_create_test.go | |
| parent | 5f21e0f8eb66791fc86c07baac80b485fd5965fc (diff) | |
| download | gitea-59d060622d375c4123ea88e2fa6c4f34d4fea4d3.tar.gz gitea-59d060622d375c4123ea88e2fa6c4f34d4fea4d3.zip | |
Improve RSS (#24335)
Follow #22719
### Major changes
1. `ServerError` doesn't do format, so remove the `%s`
2. Simplify `RenderBranchFeed` (slightly)
3. Remove unused `BranchFeedRSS`
4. Make `feed.RenderBranchFeed` respect `EnableFeed` config
5. Make `RepoBranchTagSelector.vue` respect `EnableFeed` setting,
otherwise there is always RSS icon
6. The `(branchURLPrefix + item.url).replace('src', 'rss')` doesn't seem
right for all cases, for example, the string `src` could appear in
`branchURLPrefix`, so we need a separate `rssURLPrefix`
7. The `<a>` in Vue menu needs `@click.stop`, otherwise the menu itself
would be triggered at the same time
8. Change `<a><button></button></a>` to `<a role=button>`
9. Use `{{PathEscapeSegments .TreePath}}` instead of `{{range $i, $v :=
.TreeNames}}/{{$v}}{{end}}`
Screenshot of changed parts:
<details>
</details>
### Other thoughts
Should we remove the RSS icon from the branch dropdown list? It seems
too complex for a list UI, and users already have the chance to get the
RSS feed URL from "branches" page.
---------
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: silverwind <me@silverwind.io>
Diffstat (limited to 'tests/integration/pull_create_test.go')
| -rw-r--r-- | tests/integration/pull_create_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/integration/pull_create_test.go b/tests/integration/pull_create_test.go index 3a13fb4fcb..6e2d65ca0a 100644 --- a/tests/integration/pull_create_test.go +++ b/tests/integration/pull_create_test.go @@ -22,7 +22,7 @@ func testPullCreate(t *testing.T, session *TestSession, user, repo, branch, titl // Click the PR button to create a pull htmlDoc := NewHTMLParser(t, resp.Body) - link, exists := htmlDoc.doc.Find("#new-pull-request").Parent().Attr("href") + link, exists := htmlDoc.doc.Find("#new-pull-request").Attr("href") assert.True(t, exists, "The template has changed") if branch != "master" { link = strings.Replace(link, ":master", ":"+branch, 1) |