diff options
| author | oliverpool <3864879+oliverpool@users.noreply.github.com> | 2023-02-20 09:43:04 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-20 16:43:04 +0800 |
| commit | 3596df52c09831f7f39f8416264ff267954f35a0 (patch) | |
| tree | e4234049f1337eb98db3325804b0a5ebc4b61cab /tests/integration/pull_status_test.go | |
| parent | 1d64eafe8f296e77c59c18fcda428d2b5df67ac0 (diff) | |
| download | gitea-3596df52c09831f7f39f8416264ff267954f35a0.tar.gz gitea-3596df52c09831f7f39f8416264ff267954f35a0.zip | |
Fix hidden commit status on multiple checks (#22889)
Since #22632, when a commit status has multiple checks, no check is
shown at all (hence no way to see the other checks).
This PR fixes this by always adding a tag with the
`.commit-statuses-trigger` to the DOM (the `.vm` is for vertical
alignment).
---------
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Diffstat (limited to 'tests/integration/pull_status_test.go')
| -rw-r--r-- | tests/integration/pull_status_test.go | 21 |
1 files changed, 12 insertions, 9 deletions
diff --git a/tests/integration/pull_status_test.go b/tests/integration/pull_status_test.go index e60d17edc0..736d1ee4f0 100644 --- a/tests/integration/pull_status_test.go +++ b/tests/integration/pull_status_test.go @@ -70,7 +70,12 @@ func TestPullCreate_CommitStatus(t *testing.T) { for _, status := range statusList { // Call API to add status for commit - t.Run("CreateStatus", doAPICreateCommitStatus(testCtx, commitID, status)) + t.Run("CreateStatus", doAPICreateCommitStatus(testCtx, commitID, api.CreateStatusOption{ + State: status, + TargetURL: "http://test.ci/", + Description: "", + Context: "testci", + })) req = NewRequestf(t, "GET", "/user1/repo1/pulls/1/commits") resp = session.MakeRequest(t, req, http.StatusOK) @@ -88,15 +93,13 @@ func TestPullCreate_CommitStatus(t *testing.T) { }) } -func doAPICreateCommitStatus(ctx APITestContext, commitID string, status api.CommitStatusState) func(*testing.T) { +func doAPICreateCommitStatus(ctx APITestContext, commitID string, data api.CreateStatusOption) func(*testing.T) { return func(t *testing.T) { - req := NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/statuses/%s?token=%s", ctx.Username, ctx.Reponame, commitID, ctx.Token), - api.CreateStatusOption{ - State: status, - TargetURL: "http://test.ci/", - Description: "", - Context: "testci", - }, + req := NewRequestWithJSON( + t, + http.MethodPost, + fmt.Sprintf("/api/v1/repos/%s/%s/statuses/%s?token=%s", ctx.Username, ctx.Reponame, commitID, ctx.Token), + data, ) if ctx.ExpectedCode != 0 { ctx.Session.MakeRequest(t, req, ctx.ExpectedCode) |