diff options
| author | Jason Song <i@wolfogre.com> | 2023-05-16 14:49:40 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-16 14:49:40 +0800 |
| commit | d81659d03947ac4533099089c5f442437e1d6887 (patch) | |
| tree | 2bf4ac98a99406d986c87e2032456c21c8d48491 /tests/integration | |
| parent | 30d922226778a469f01bbb1b933e65428f9266df (diff) | |
| download | gitea-d81659d03947ac4533099089c5f442437e1d6887.tar.gz gitea-d81659d03947ac4533099089c5f442437e1d6887.zip | |
Respect original content when creating secrets (#24745)
Fix #24721.
Follow what GitHub does:
- Don't trim spaces for secrets.
- Newline should be `\n` instead of `\r\n`.
Did some tests with:
```yaml
name: secrets
on: push
jobs:
show_secrets:
runs-on: ubuntu-latest
steps:
- name: Dump secrets context
run: echo '${{ toJSON(secrets) }}' | base64
```
`AAAAAA`:
```text
AAAAAA
AAAAAA
```
`BBBBBB`:
```text
BBBBBB
BBBBBB
```
On GitHub:
<img width="675" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/0ec60652-c2a3-47bb-9f9d-7e81665355a8">
On Gitea (before):
<img width="673" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/cce818bf-5edc-4656-86e1-2c81c304cdb2">
On Gitea (after):
<img width="673" alt="image"
src="https://github.com/go-gitea/gitea/assets/9418365/0b3b15af-4d48-4bab-a334-4738a1b0eb4a">
Diffstat (limited to 'tests/integration')
0 files changed, 0 insertions, 0 deletions