diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-03-09 23:48:52 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-09 09:48:52 -0600 |
| commit | 542cec98f8c07e0f046a35f1d516807416536e74 (patch) | |
| tree | 31a6811704630fb6f057aac2193bf1f510daf19e /tests/mssql.ini.tmpl | |
| parent | e52ac62d8e645c721060e6c9a2b0ab77eedf8fd6 (diff) | |
| download | gitea-542cec98f8c07e0f046a35f1d516807416536e74.tar.gz gitea-542cec98f8c07e0f046a35f1d516807416536e74.zip | |
Refactor merge/update git command calls (#23366)
Follow #22568
* Remove unnecessary ToTrustedCmdArgs calls
* the FAQ in #22678
* Quote: When using ToTrustedCmdArgs, the code will be very complex (see
the changes for examples). Then developers and reviewers can know that
something might be unreasonable.
* The `signArg` couldn't be empty, it's either `-S{keyID}` or
`--no-gpg-sign`.
* Use `signKeyID` instead, add comment "empty for no-sign, non-empty to
sign"
* 5-line code could be extracted to a common `NewGitCommandCommit()` to
handle the `signKeyID`, but I think it's not a must, current code is
clear enough.
Diffstat (limited to 'tests/mssql.ini.tmpl')
0 files changed, 0 insertions, 0 deletions