diff options
author | silverwind <me@silverwind.io> | 2023-08-25 18:03:14 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-08-25 16:03:14 +0000 |
commit | 8b5c081d766bc7be725b07a8abfb2d8f39c45fd3 (patch) | |
tree | ef15523e1c7735d0a9c86a8646ead75f00213c53 /web_src/css/features | |
parent | f626366f530075a23de2a821f232968e71011828 (diff) | |
download | gitea-8b5c081d766bc7be725b07a8abfb2d8f39c45fd3.tar.gz gitea-8b5c081d766bc7be725b07a8abfb2d8f39c45fd3.zip |
Remove fomantic loader module (#26670)
Replace Fomantic `loader` CSS module with our existing `is-loading`
spinner. Only three places in the UI used this module, which are
pictured here:
imagediff:
<img width="1237" alt="Screenshot 2023-08-22 at 22 18 01"
src="https://github.com/go-gitea/gitea/assets/115237/b0d82531-f05e-43c6-9e5b-1bfc268c056d">
webauthn:
<img width="894" alt="Screenshot 2023-08-22 at 22 05 05"
src="https://github.com/go-gitea/gitea/assets/115237/7b583425-d944-474a-a57a-22a65bbd8b29">
heatmap (I removed the previous loading text, it was unreadable because
it was tiny and on fast machines only visible for a fraction of a
second):
<img width="764" alt="Screenshot 2023-08-22 at 22 18 44"
src="https://github.com/go-gitea/gitea/assets/115237/1c7472d6-3e17-4224-a992-d8c0b380cc73">
Also, heatmap container does not resize any more after loading now and
previous duplicate id `user-heatmap` is gone.
---------
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Diffstat (limited to 'web_src/css/features')
-rw-r--r-- | web_src/css/features/heatmap.css | 32 |
1 files changed, 9 insertions, 23 deletions
diff --git a/web_src/css/features/heatmap.css b/web_src/css/features/heatmap.css index d0cd2b5734..364754751a 100644 --- a/web_src/css/features/heatmap.css +++ b/web_src/css/features/heatmap.css @@ -2,7 +2,15 @@ width: 100%; font-size: 9px; position: relative; - min-height: 125px; +} + +/* before the Vue component is mounted, show a loading indicator with dummy size */ +/* the ratio is guesswork, see https://github.com/razorness/vue3-calendar-heatmap/issues/26 */ +#user-heatmap.is-loading { + aspect-ratio: 5.415; /* the size is about 790 x 145 */ +} +.user.profile #user-heatmap.is-loading { + aspect-ratio: 5.645; /* the size is about 953 x 169 */ } #user-heatmap text { @@ -32,37 +40,15 @@ } @media (max-width: 1200px) { - #user-heatmap { - min-height: 105px; - } #user-heatmap .total-contributions { left: 21px; } } @media (max-width: 1000px) { - #user-heatmap { - min-height: 80px; - } #user-heatmap .total-contributions { font-size: 10px; left: 17px; bottom: -4px; } } - -.user.profile #user-heatmap { - min-height: 135px; -} - -@media (max-width: 1200px) { - .user.profile #user-heatmap { - min-height: 115px; - } -} - -@media (max-width: 1000px) { - .user.profile #user-heatmap { - min-height: 90px; - } -} |