diff options
| author | wxiaoguang <wxiaoguang@gmail.com> | 2023-03-23 11:24:16 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-03-23 11:24:16 +0800 |
| commit | 389e83f7eb68c43f6f0313b20acde547aef12442 (patch) | |
| tree | 08edb4fa00247fb394e7f065614f9fb7f55336f4 /web_src/css | |
| parent | 1d35fa0e784dffcadacb2322a3d7ac3ec2ff89b2 (diff) | |
| download | gitea-389e83f7eb68c43f6f0313b20acde547aef12442.tar.gz gitea-389e83f7eb68c43f6f0313b20acde547aef12442.zip | |
Improve `<SvgIcon>` to make it output `svg` node and optimize performance (#23570)
Before, the Vue `<SvgIcon>` always outputs DOM nodes like:
```html
<span class="outer-class">
<svg class="class-name-defined" ...></svg>
</span>
```
The `span` is redundant and I guess such layout and the inconsistent
`class/class-name` attributes would cause bugs sooner or later.
This PR makes the `<SvgIcon>` clear, and it's faster than before,
because it doesn't need to parse the whole SVG string.
Before:
<details>
</details>
After:
---------
Co-authored-by: silverwind <me@silverwind.io>
Diffstat (limited to 'web_src/css')
| -rw-r--r-- | web_src/css/base.css | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/web_src/css/base.css b/web_src/css/base.css index 1077a0eebd..e3b3fece37 100644 --- a/web_src/css/base.css +++ b/web_src/css/base.css @@ -2420,18 +2420,6 @@ a.ui.basic.label:hover { height: 2.1666em !important; } -span.green .svg { - color: var(--color-green); -} - -span.red .svg { - color: var(--color-red); -} - -span.purple .svg { - color: var(--color-purple); -} - .migrate .svg.gitea-git { color: var(--color-git); } |